From: Simon Marchi <simark@simark.ca>
To: Ruslan Kabatsayev <b7.10110111@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4] Align natural-format register values to the same column
Date: Sun, 04 Feb 2018 21:59:00 -0000 [thread overview]
Message-ID: <476b9768-30b7-73ce-ec5b-a19c7656019d@simark.ca> (raw)
In-Reply-To: <1517658143-946-1-git-send-email-b7.10110111@gmail.com>
On 2018-02-03 06:42 AM, Ruslan Kabatsayev wrote:
> Currently, commands such as "info reg", "info all-reg", as well as register
> window in the TUI print badly aligned columns, like here:
>
> eax 0x1 1
> ecx 0xffffd3e0 -11296
> edx 0xffffd404 -11260
> ebx 0xf7fa5ff4 -134586380
> esp 0xffffd390 0xffffd390
> ebp 0xffffd3c8 0xffffd3c8
> esi 0x0 0
> edi 0x0 0
> eip 0x8048b60 0x8048b60 <main+16>
> eflags 0x286 [ PF SF IF ]
> cs 0x23 35
> ss 0x2b 43
> ds 0x2b 43
> es 0x2b 43
> fs 0x0 0
> gs 0x63 99
>
> After this patch, these commands print the third column values consistently
> aligned one under another, provided the second column is not too long.
> Originally, the third column was (attempted to be) aligned using a simple tab
> character. This patch changes the alignment to spaces only. The tests checking
> the output and expecting the single tab have been fixed in a previous patch, so
> this change doesn't break any.
Thanks, this version LGTM, please push.
Simon
next prev parent reply other threads:[~2018-02-04 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-03 11:42 Ruslan Kabatsayev
2018-02-04 21:59 ` Simon Marchi [this message]
2018-02-05 8:34 ` Ruslan Kabatsayev
2018-06-05 18:20 ` [PATCH] Fix "info registers" regexes in gdb.base/jit-reader.exp Simon Marchi
2018-06-22 17:43 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476b9768-30b7-73ce-ec5b-a19c7656019d@simark.ca \
--to=simark@simark.ca \
--cc=b7.10110111@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox