From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id B5272383E82B for ; Tue, 23 Jun 2020 14:26:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B5272383E82B Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-400-joh0feEOP7CK2zt1oCcpkA-1; Tue, 23 Jun 2020 10:26:35 -0400 X-MC-Unique: joh0feEOP7CK2zt1oCcpkA-1 Received: by mail-wr1-f69.google.com with SMTP id b14so15666698wrp.0 for ; Tue, 23 Jun 2020 07:26:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4HYRd8+WVzcj4bYkCHzy2wnUQr89CExhfKX2BtHbBgY=; b=EzSHkKYytArbdL/Knzf/sqTwPdo2ZiT/M5WWymABEqUI30jicQG9o8y12MBBjlUQmG X72j/BZaWI9qHGUetOcnyw+ika21zMwxQPbWK11r9SF72xg76tpmzo2fl3ErtUyH2/Iv sVye2cnJ+e5xkaOd5UD6BHQTugQg0Pc6UTGyqvZLsOU+Ki6JUSPoTdz4BQ2Kbq81iCOG K/+BtupfPyPrSKNn93aCuQEiA3wSwCr51HshMQtI1TGhtButTCQ6udYu2DQ+P9bXGmcp sa1dzcmK/gJtmGZYqzQx4HTaXgD6v2RSpA0c43JJzqB6k7Lu9P6/Iv3MNLhnGD0J284j wdyQ== X-Gm-Message-State: AOAM530D+AXy0TdAD9g5jvw8lGfVx9nlxnYh/LhydTSwpobZVWyQkiCU OkeEj0mrBS0ykI3cGYSclyiarMhZUIhvEnjQk0X7IgS0pkZYI48P6SeUOQpPnRIoCsXJMpvikSy 0BJjlfqH7rlXUqgtsIZ39HA== X-Received: by 2002:a1c:7d54:: with SMTP id y81mr16549251wmc.110.1592922393577; Tue, 23 Jun 2020 07:26:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuZe8/Jnizo/ssGF5HvLWfLwEiiCDAN2Xli7CRfsGvft6eftnsQWYkfdAFHENoTnmE7AbYAA== X-Received: by 2002:a1c:7d54:: with SMTP id y81mr16549233wmc.110.1592922393375; Tue, 23 Jun 2020 07:26:33 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id w17sm23929530wra.42.2020.06.23.07.26.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2020 07:26:32 -0700 (PDT) Subject: Re: [PATCH 28/28] Decouple inferior_ptid/inferior_thread(); dup ptids in thread list (PR/25412) To: Andrew Burgess References: <20200414175434.8047-1-palves@redhat.com> <20200414175434.8047-29-palves@redhat.com> <20200623133750.GO2737@embecosm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <475a7fa3-07b1-1830-38e5-5c3b7c6cb7a1@redhat.com> Date: Tue, 23 Jun 2020 15:26:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200623133750.GO2737@embecosm.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2020 14:26:39 -0000 On 6/23/20 2:37 PM, Andrew Burgess wrote: > This commit causes a regression for gdb.gdb/unittest.exp when GDB is > configured with --enable-targets=all. > > The failure is: > > gdb/thread.c:95: internal-error: thread_info* inferior_thread(): Assertion `current_thread_ != nullptr' failed. > > Here's a partial backtrace: > > #8 0x00000000013e4d0f in internal_error (file=0x16c55c7 "../../src.dev-1/gdb/thread.c", line=95, > fmt=0x16c54d9 "%s: Assertion `%s' failed.") at ../../src.dev-1/gdbsupport/errors.cc:55 > #9 0x0000000000c34e63 in inferior_thread () at ../../src.dev-1/gdb/thread.c:95 > #10 0x0000000000a73d62 in get_current_regcache () at ../../src.dev-1/gdb/regcache.c:391 > #11 0x00000000009051c0 in current_options () at ../../src.dev-1/gdb/mep-tdep.c:873 > #12 0x00000000009052eb in mep_register_name (gdbarch=0x33862a0, regnr=152) at ../../src.dev-1/gdb/mep-tdep.c:958 > #13 0x00000000009054aa in mep_register_reggroup_p (gdbarch=0x33862a0, regnum=152, group=0x26334c0 ) > at ../../src.dev-1/gdb/mep-tdep.c:1029 > #14 0x00000000007975e8 in gdbarch_register_reggroup_p (gdbarch=0x33862a0, regnum=152, reggroup=0x26334c0 ) > at ../../src.dev-1/gdb/gdbarch.c:3595 > #15 0x0000000000a7355a in reg_buffer::save(gdb::function_view) ( > this=0x7fffffffad00, cooked_read=...) at ../../src.dev-1/gdb/regcache.c:248 > #16 0x0000000000780b36 in readonly_detached_regcache::readonly_detached_regcache(gdbarch*, gdb::function_view) (this=0x7fffffffad00, gdbarch=0x33862a0, cooked_read=...) > at ../../src.dev-1/gdb/regcache.h:455 > #17 0x0000000000a73409 in readonly_detached_regcache::readonly_detached_regcache (this=0x7fffffffad00, src=...) > at ../../src.dev-1/gdb/regcache.c:213 > #18 0x0000000000a773b5 in selftests::cooked_read_test (gdbarch=0x33862a0) at ../../src.dev-1/gdb/regcache.c:1690 > #19 0x0000000000b48c29 in selftests::gdbarch_selftest::operator() (this=0x320fef0) > at ../../src.dev-1/gdb/selftest-arch.c:73 > #20 0x00000000013fe5ac in selftests::run_tests (filter=0x0) at ../../src.dev-1/gdbsupport/selftest.cc:88 > #21 0x00000000008e78ba in maintenance_selftest (args=0x0, from_tty=1) at ../../src.dev-1/gdb/maint.c:1044 > #22 0x00000000005b0557 in do_const_cfunc (c=0x32004f0, args=0x0, from_tty=1) > at ../../src.dev-1/gdb/cli/cli-decode.c:95 > #23 0x00000000005b3839 in cmd_func (cmd=0x32004f0, args=0x0, from_tty=1) at ../../src.dev-1/gdb/cli/cli-decode.c:2113 > #24 0x0000000000c4953b in execute_command (p=0x2924895 "", from_tty=1) at ../../src.dev-1/gdb/top.c:655 > #25 0x0000000000759c26 in command_handler (command=0x2924880 "maintenance selftest ") > at ../../src.dev-1/gdb/event-top.c:588 > #26 0x000000000075a052 in command_line_handler (rl=...) at ../../src.dev-1/gdb/event-top.c:773 > > I suspect that the problem might be this line in regcache.c:cooked_read_test: > > /* Switch to the mock thread. */ > scoped_restore restore_inferior_ptid > = make_scoped_restore (&inferior_ptid, mock_ptid); > > My suspicion from a quick read of your patch above is that we need to > do more than just set inferior_ptid here now. Indeed. Thanks for reporting it. I fixed this in gdbarch-selftests.c, where this code is duplicated, but missed regcache.c. I'll fix it. Thanks, Pedro Alves