From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14281 invoked by alias); 3 Dec 2007 03:53:41 -0000 Received: (qmail 14273 invoked by uid 22791); 3 Dec 2007 03:53:40 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.173) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 03 Dec 2007 03:53:34 +0000 Received: by ug-out-1314.google.com with SMTP id h2so2011775ugf for ; Sun, 02 Dec 2007 19:53:33 -0800 (PST) Received: by 10.67.122.12 with SMTP id z12mr2926843ugm.1196654013417; Sun, 02 Dec 2007 19:53:33 -0800 (PST) Received: from ?78.130.100.26? ( [78.130.100.26]) by mx.google.com with ESMTPS id b35sm230146ugd.2007.12.02.19.53.31 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 02 Dec 2007 19:53:33 -0800 (PST) Message-ID: <475364B4.90405@portugalmail.pt> Date: Mon, 03 Dec 2007 03:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org, Lerele Subject: Re: [gdbserver/win32] (4/11) New interrupting method References: <4737B553.2040302@portugalmail.pt> <20071201185611.GC24231@caradoc.them.org> In-Reply-To: <20071201185611.GC24231@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00037.txt.bz2 Daniel Jacobowitz wrote: > On Mon, Nov 12, 2007 at 02:07:15AM +0000, Pedro Alves wrote: >> 2007-11-12 Leo Zayas >> Pedro Alves >> >> * win32-low.c (soft_interrupt_requested, faked_breakpoint): New >> global variables. >> (child_add_thread): Minor cleanup. >> (child_continue): Resume artificially suspended threads before >> calling ContinueDebugEvent. >> (suspend_one_thread): New. >> (fake_breakpoint_event): New. >> (get_child_debug_event): Change return type to int. Check here if >> gdb sent an interrupt request. If a soft interrupt was >> requested, fake a breakpoint event. Return 0 if there is no event >> to handle, and 1 otherwise. >> (win32_wait): Don't check here if gdb sent an interrupt request. >> Ensure there is a valid event to handle. >> (win32_request_interrupt): Add soft interruption method as last resort. > > This looks OK to me. > Thanks, checked in. -- Pedro Alves