From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19683 invoked by alias); 24 Nov 2007 12:43:02 -0000 Received: (qmail 19675 invoked by uid 22791); 24 Nov 2007 12:43:02 -0000 X-Spam-Check-By: sourceware.org Received: from nf-out-0910.google.com (HELO nf-out-0910.google.com) (64.233.182.186) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 24 Nov 2007 12:42:54 +0000 Received: by nf-out-0910.google.com with SMTP id b11so101425nfh for ; Sat, 24 Nov 2007 04:42:49 -0800 (PST) Received: by 10.82.150.20 with SMTP id x20mr1131903bud.1195908168661; Sat, 24 Nov 2007 04:42:48 -0800 (PST) Received: from ?88.210.72.146? ( [88.210.72.146]) by mx.google.com with ESMTPS id d24sm101196nfh.2007.11.24.04.42.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 24 Nov 2007 04:42:48 -0800 (PST) Message-ID: <47481C2F.4010009@portugalmail.pt> Date: Sat, 24 Nov 2007 12:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Lerele CC: gdb-patches@sourceware.org Subject: Re: [win32] Fix suspend count handling References: <47437D3A.3000107@portugalmail.pt> <000001c82c31$4a57b220$df071660$@u-strasbg.fr> <4053daab0711210543w4b241e1ek2371e887f3c4f7d2@mail.gmail.com> <000401c82c48$a450df10$ecf29d30$@u-strasbg.fr> <4053daab0711210708o607018b9n8b63147a8498a207@mail.gmail.com> <4053daab0711211019r15f3a862g677080b65b4d8e71@mail.gmail.com> <4744BCCE.60705@portugalmail.pt> <20071123010744.GA31180@ednor.casa.cgf.cx> <4746A922.30404@champenstudios.com> <47471C47.80909@champenstudios.com> In-Reply-To: <47471C47.80909@champenstudios.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00449.txt.bz2 Lerele wrote: > > I'd also like to ask you a question, concerning a comment from Pedro > several messages back that has stayed around in my mind since then. > > It's not related with this specific thread title, but since it's > gdbserver/win32 related, I haven't found appropriate to open a new > thread just for this simple question. > > The issue is near the end of: > http://sourceware.org/ml/gdb-patches/2007-11/msg00041.html > > It's about the fact of gdb win32-nat.c some time ago having the > interrupt functionality similar to the one that has been recently > implemented using SuspendThread (versus using DebugBreak kind of > functions). Pedro commented back then that win32-nat.c did have sometime > in the past a similar implementation [that must have been dropped]. > Do you know/remember if it was dropped for a specific reason? > Humm, I guess I mistaked win32-nat.c for the winpdo-nat.c files on Apple's gdb: See in: http://www.opensource.apple.com/darwinsource/tarballs/other/gdb-186.1.tar.gz In src/gdb-next/winpdo-nat.c, you'll see a SuspendThreads mechanism. The file header states 1996 as the latest copyright year, but they may have easilly failed to update it. I'm not sure if win32-nat ever had this mechanism, or if it was only added by Apple. Our cvs history only goes back till 1999. I did say: "I *think* that if...". :-) -- Pedro Alves