Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro_alves@portugalmail.pt>
To: gdb-patches@sourceware.org, Lerele <lerele@champenstudios.com>
Subject: [gdbserver/win32] (2/11) Don't fetch registers from a dead inferior
Date: Mon, 12 Nov 2007 02:06:00 -0000	[thread overview]
Message-ID: <4737B536.8040106@portugalmail.pt> (raw)

[-- Attachment #1: Type: text/plain, Size: 136 bytes --]

Hi,

Noticed this when adding a few warnings.  We shouldn't
fetch thread contexts after the inferior has exited.

Cheers,
Pedro Alves



[-- Attachment #2: gdbserver_exited_dontfetch.diff --]
[-- Type: text/x-diff, Size: 721 bytes --]

2007-11-12  Pedro Alves  <pedro_alves@portugalmail.pt>

	* win32-low.c (win32_wait): Don't read from the inferior when it
	has already exited.

---
 gdb/gdbserver/win32-low.c |    3 ---
 1 file changed, 3 deletions(-)

Index: src/gdb/gdbserver/win32-low.c
===================================================================
--- src.orig/gdb/gdbserver/win32-low.c	2007-11-11 23:12:28.000000000 +0000
+++ src/gdb/gdbserver/win32-low.c	2007-11-11 23:15:20.000000000 +0000
@@ -1390,9 +1390,6 @@ win32_wait (char *status)
 		    our_status.value.integer));
 
 	  *status = 'W';
-
-	  child_fetch_inferior_registers (-1);
-
 	  return our_status.value.integer;
 	case TARGET_WAITKIND_STOPPED:
  	case TARGET_WAITKIND_LOADED:



             reply	other threads:[~2007-11-12  2:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12  2:06 Pedro Alves [this message]
2007-12-01 18:51 ` Daniel Jacobowitz
2007-12-03  3:53   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4737B536.8040106@portugalmail.pt \
    --to=pedro_alves@portugalmail.pt \
    --cc=gdb-patches@sourceware.org \
    --cc=lerele@champenstudios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox