From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-52032-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13461 invoked by alias); 7 Nov 2007 14:52:55 -0000
Received: (qmail 13452 invoked by uid 22791); 7 Nov 2007 14:52:54 -0000
X-Spam-Check-By: sourceware.org
Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 07 Nov 2007 14:52:50 +0000
Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) 	by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id lA7Eqk9h443770 	for <gdb-patches@sourceware.org>; Wed, 7 Nov 2007 14:52:47 GMT
Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) 	by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.6) with ESMTP id lA7Eqk1E1597536 	for <gdb-patches@sourceware.org>; Wed, 7 Nov 2007 15:52:46 +0100
Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) 	by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lA7EqMMw008848 	for <gdb-patches@sourceware.org>; Wed, 7 Nov 2007 15:52:46 +0100
Received: from bbkeks.boeblingen.de.ibm.com ([9.146.120.131]) 	by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id lA7EqKgj008742 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); 	Wed, 7 Nov 2007 15:52:21 +0100
Message-ID: <4731D0B9.8000809@de.ibm.com>
Date: Wed, 07 Nov 2007 14:52:00 -0000
From: Markus Deuling <deuling@de.ibm.com>
User-Agent: Thunderbird 2.0.0.6 (X11/20070728)
MIME-Version: 1.0
To: gdb-patches@sourceware.org
CC: Mark Kettenis <mark.kettenis@xs4all.nl>,         Daniel Jacobowitz <drow@false.org>,         Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] [02/05] Get rid of current_gdbarch in hppa-linux-nat.c
References: <47319D46.8080904@de.ibm.com> <200711071130.lA7BUDaD014732@brahms.sibelius.xs4all.nl> <4731A642.6080402@de.ibm.com> <20071107125809.GA14179@caradoc.them.org>
In-Reply-To: <20071107125809.GA14179@caradoc.them.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-11/txt/msg00128.txt.bz2

Daniel Jacobowitz schrieb:

> That doesn't make any sense.  The error is there to make sure we don't
> access memory outside the array.
> 

What this patch does is transform

  if ((unsigned) regno >= gdbarch_num_regs (current_gdbarch))
    error (_("Invalid register number %d."), regno);


into

  if ((unsigned) regno >= gdbarch_num_regs (gdbarch))
    error (_("Invalid register number %d."), regno);


The gdbarch comes from regcache in {fetch,store}_register. Why is that wrong ?


-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com