Hi, Ulrich Weigand schrieb: > Markus Deuling wrote: > >> this patchs adds gdbarch parameter to legacy_virtual_frame_pointer and updates its >> sole implementation in arch-utils. > > Huh? There are three further instances of gdbarch_virtual_frame_pointer > (in m32c-tdep.c, mips-tdep.c, spu-tdep.c). The patch as-is would break > those platforms ... > > I guess if those are fixed it would be OK to convert the function for now; > however, in the long run, the virtual_frame_pointer function needs to be > eliminated -- the tracepoint framework should really be getting this data > from the debug information. hm, sorry. No idea why I've overseen them. Here is a new patch tested by gdb_mbuild. Ok to commit? ChangeLog: * gdbarch.sh (legacy_virtual_frame_pointer): Add gdbarch parameter. * gdbarch.{c,h}: Regenerate. * arch-utils.c (legacy_virtual_frame_pointer): Add gdbarch parameter. Replace current_gdbarch by gdbarch. * m32c-tdep.c (m32c_virtual_frame_pointer): Likewise. * mips-tdep.c (mips_virtual_frame_pointer): Likewise. * spu-tdep.c (spu_virtual_frame_pointer): Likewise. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com