From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27322 invoked by alias); 31 Oct 2007 10:48:07 -0000 Received: (qmail 27217 invoked by uid 22791); 31 Oct 2007 10:48:06 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 31 Oct 2007 10:48:02 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l9VAlxeS258856 for ; Wed, 31 Oct 2007 10:47:59 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9VAlxAb2142364 for ; Wed, 31 Oct 2007 11:47:59 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9VAlwDR029191 for ; Wed, 31 Oct 2007 11:47:59 +0100 Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-41.boeblingen.de.ibm.com [9.152.248.41]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l9VAlvNa029165 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 31 Oct 2007 11:47:58 +0100 Message-ID: <47285CF5.1040206@de.ibm.com> Date: Wed, 31 Oct 2007 10:48:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: GDB Patches CC: Ulrich Weigand Subject: [rfc] [14/15] Add gdbarch to register_name callback in frv-tdep.c Content-Type: multipart/mixed; boundary="------------030000050409080105060205" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00850.txt.bz2 This is a multi-part message in MIME format. --------------030000050409080105060205 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 549 Hi, this patch adds gdbarch to register_name callback in frv-tdep.c. The macro CURRENT_VARIANT included current_gdbarch. This patch replaces its occurences by its expression and then replaces current_gdbarch. Is this ok to commit? ChangeLog: * frv-tdep.c (frv_register_name): Add gdbarch parameter. Replace current_gdbarch by gdbarch. (frv_register_name, frv_check_watch_resources): Replace macro CURRENT_VARIANT by its expression. (CURRENT_VARIANT): Remove. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------030000050409080105060205 Content-Type: text/plain; name="diff-frv-tdep" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-frv-tdep" Content-length: 1104 diff -urpN src/gdb/frv-tdep.c dev/gdb/frv-tdep.c --- src/gdb/frv-tdep.c 2007-10-24 23:08:23.000000000 +0200 +++ dev/gdb/frv-tdep.c 2007-10-31 06:57:30.000000000 +0100 @@ -91,7 +91,6 @@ struct gdbarch_tdep char **register_names; }; -#define CURRENT_VARIANT (gdbarch_tdep (current_gdbarch)) /* Return the FR-V ABI associated with GDBARCH. */ enum frv_abi @@ -278,14 +277,14 @@ set_variant_scratch_registers (struct gd } static const char * -frv_register_name (int reg) +frv_register_name (struct gdbarch *gdbarch, int reg) { if (reg < 0) return "?toosmall?"; if (reg >= frv_num_regs + frv_num_pseudo_regs) return "?toolarge?"; - return CURRENT_VARIANT->register_names[reg]; + return gdbarch_tdep (gdbarch)->register_names[reg]; } @@ -1282,7 +1281,7 @@ frv_return_value (struct gdbarch *gdbarc int frv_check_watch_resources (int type, int cnt, int ot) { - struct gdbarch_tdep *var = CURRENT_VARIANT; + struct gdbarch_tdep *var = gdbarch_tdep (current_gdbarch); /* Watchpoints not supported on simulator. */ if (strcmp (target_shortname, "sim") == 0) --------------030000050409080105060205--