Re: [patch] Add support for PPC Altivec registers in core files

Jim Blandy
2007-10-23T15:08:14Z

Carlos Eduardo Seo <cseo at linux.vnet.ibm.com> writes:
> Carlos Eduardo Seo
> Software Engineer
> IBM Linux Technology Center
> 2007-10-22 Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
>
> * ppc-linux-tdep.c (ppc32_linux_reg_offsets): Corrected
> swapped offsets and VRSAVE offset.
> (ppc64_linux_reg_offsets): Corrected swapped offsets.
> (ppc32_linux_vrregset): Added. Necessary for reading the
> Altivec registers from the core file.

I can't approve this, but I can pick nits. :)

The best place to explain why ppc32_linux_vrregset is necessary is in
a comment above the definition in the code, not in the ChangeLog file.