From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32330 invoked by alias); 25 Oct 2007 20:32:11 -0000 Received: (qmail 32306 invoked by uid 22791); 25 Oct 2007 20:32:07 -0000 X-Spam-Check-By: sourceware.org Received: from igw1.br.ibm.com (HELO igw1.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 25 Oct 2007 20:32:01 +0000 Received: from mailhub3.br.ibm.com (mailhub3 [9.18.232.110]) by igw1.br.ibm.com (Postfix) with ESMTP id 7795C32C1CE for ; Thu, 25 Oct 2007 18:29:29 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9PKHk033022960 for ; Thu, 25 Oct 2007 18:31:58 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9PJfnHu020460 for ; Thu, 25 Oct 2007 16:41:49 -0300 Received: from [9.18.238.59] ([9.18.238.59]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l9PJfnmV020439 for ; Thu, 25 Oct 2007 16:41:49 -0300 Message-ID: <4720F17E.6000508@linux.vnet.ibm.com> Date: Thu, 25 Oct 2007 20:32:00 -0000 From: Carlos Eduardo Seo User-Agent: Thunderbird 2.0.0.6 (X11/20070907) MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: Problems while debugging fortran References: <471F70C0.3000206@linux.vnet.ibm.com> <20071024193336.GI11797@adacore.com> <20071024195719.GA16009@caradoc.them.org> <471FA810.6080506@linux.vnet.ibm.com> <471FBF9E.5000607@linux.vnet.ibm.com> <20071024220648.GL11797@adacore.com> <472098B2.5010605@linux.vnet.ibm.com> <20071025190627.GA4157@adacore.com> <20071025193515.GA3729@caradoc.them.org> In-Reply-To: <20071025193515.GA3729@caradoc.them.org> OpenPGP: id=8BFFA900 Content-Type: multipart/mixed; boundary="------------000007070103050109030609" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00674.txt.bz2 This is a multi-part message in MIME format. --------------000007070103050109030609 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 653 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Daniel Jacobowitz wrote: > On Thu, Oct 25, 2007 at 12:30:41PM -0700, Jim Blandy wrote: >> This would be fine with me, too. > > Me too. > Ok. I added Joel's comments to the patch, replacing the original ones. If no one has any other objections, I can commit this later. Regards, - -- Carlos Eduardo Seo Software Engineer IBM Linux Technology Center -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHIPF+qvq7Aov/qQARAjcnAJ0SBFHaOnQrkzN2C0hsKuuYr5bhLQCeJLMS OI9Fa1ZuhUQ7/h9lV19q86w= =+biI -----END PGP SIGNATURE----- --------------000007070103050109030609 Content-Type: text/x-patch; name="fortran-main.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fortran-main.diff" Content-length: 1282 2007-10-25 Wu Zhou Carlos Eduardo Seo Joel Brobecker * dwarf2read.c (read_partial_die): check the value of DW_AT_calling_convention in Fortran programs. Index: src/gdb/dwarf2read.c =================================================================== --- src.orig/gdb/dwarf2read.c +++ src/gdb/dwarf2read.c @@ -5616,6 +5616,19 @@ read_partial_die (struct partial_die_inf case DW_AT_byte_size: part_die->has_byte_size = 1; break; + case DW_AT_calling_convention: + /* In Fortran programs compiled with XLF, the only way we have found + so far to identify the main procedure is by using the fact that + the calling convention is different from the other procedures: + The DW_AT_calling_convention attribute is set to DW_CC_program. + + This is not the intent of this attribute as documented in the + DWARF standard, but we haven't found any other distinctive + characteristic of the main procedure, so we check the calling + convention for Fortran compilation units. */ + if ((DW_UNSND (&attr) == DW_CC_program) && (cu->language == language_fortran)) + set_main_name (part_die->name); + break; default: break; } --------------000007070103050109030609 Content-Type: application/octet-stream; name="fortran-main.diff.sig" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fortran-main.diff.sig" Content-length: 90 iD8DBQBHIPF+qvq7Aov/qQARAnDNAJ0ccv7padvKqQXUDbFPaNR9STEx7wCe OPTkgw3UuejJHFh8SAxAtq7K9mk= --------------000007070103050109030609--