From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec107.isp.belgacom.be (mailsec107.isp.belgacom.be [195.238.20.103]) by sourceware.org (Postfix) with ESMTPS id 597013972C31 for ; Thu, 21 May 2020 13:32:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 597013972C31 IronPort-SDR: j2zCFYCCKLEXdPw5cBLVXI4pScn8ak5v37HBpWqOhETbsZdowBUG/4L1e2nmXqGmcgrk8rH9hB o+U/bsCAXJqYpu2ywNRJj0nn7g1TIMq4PQbbeK2inWr/3wDu15127Zk81ABHyIPYhNP/KOiDy6 ODX7i7+eYH+dAtUPzF9mxwfxn8Reh7MBGPcbAbais5zJYibpzYmWDvcDoyTmJHv0okWOg+tFqU tild/K5yaBkG0ahUqekHZyuL4U0xX1mwQ/YBie9NmlathySDGk0ogo830nEE1LLCG4osToCgmv 9CA= IronPort-PHdr: =?us-ascii?q?9a23=3AVkGRFBIiuBJve5QrndmcpTZWNBhigK39O0sv0r?= =?us-ascii?q?FitYgXKvTyrarrMEGX3/hxlliBBdydt6sZzbOP6uu+AiQp2tWoiDg6aptCVh?= =?us-ascii?q?sI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFR?= =?us-ascii?q?rhKAF7Ovr6GpLIj8Swyuu+54Dfbx9HiTagYb5+Ngi6oRjMusUZgIZvJLs6xw?= =?us-ascii?q?fUrHdPZ+lY335jK0iJnxb76Mew/Zpj/DpVtvk86cNOUrj0crohQ7BAAzsoL2?= =?us-ascii?q?465MvwtRneVgSP/WcTUn8XkhVTHQfI6gzxU4rrvSv7sup93zSaPdHzQLspVz?= =?us-ascii?q?mu87tnRRn1gyocKTU37H/YhdBxjKJDoRKuuRp/w5LPYIqIMPZyZ77Rcc8GSW?= =?us-ascii?q?ZEWMtaSi5PDZ6mb4YXDOQPIOZWoZfzqVQMoxuxGQejC+zgxDJTmn/737c33/?= =?us-ascii?q?g9HQzc3gEtGc8FvnTOrNXyMacfSfq7zKnJzTXHbvNWwS/955bVeR8hu/6MR7?= =?us-ascii?q?VwcdPMyUkuCQzFlE6QopHiMjON1uQNsmyb7+t4VeK3lWErsQ9wrSK1xscrk4?= =?us-ascii?q?nJm4MVxU7e9SVi24s1Pt64SU59YdG6DJtcrTqVOJVvT84kXmpntzo0xKcctp?= =?us-ascii?q?6nYCgF1o4nxxjHZvCZbYSF4Q7uWemNLTtkhn9oeL2yiguy/0S8xeDyWcm63U?= =?us-ascii?q?tEoydBjNTCuG4A2hLQ58WERPZw/0es1DiA2g3X6+xJJ10/m6nDK5M53LI8i5?= =?us-ascii?q?gevV7eEiL4mUj6lqybelg+9uWm5enqZKjtqIWGOI9ukA7+N7wjmsm4AeslLA?= =?us-ascii?q?cDR3Ob+eGg1L37+k35XalKguU2kqbHtJDaItwWpqukDANN04Yj7QiwDyu+3d?= =?us-ascii?q?gGgHUKLkhJdA+JgoXoIV3DI+30Ae2xjlmiiDtrwurJPrzlApXDNHjDl7LhcK?= =?us-ascii?q?5l605cyQozydFf54pMCr4fOv7yVFX+tMbfDh8gLgy0wvjoCM9m1o4FQmKPAa?= =?us-ascii?q?+YMKXMvl+U/O4gOPeDaJcPuDnhM/gl++LujXghlF8FZ6ap2YUXZ26jHvl9OU?= =?us-ascii?q?WWf2fjgtcbHmcWpAYxUOvqiFiaWz5Je3myR7485i08CI++EYfDQYWtjaed3C?= =?us-ascii?q?ehGZ1WY35JC1CWHXj0cIWEXu8GaDiOLc95jjwESb+hRpcu1R6zrwD20qJnIf?= =?us-ascii?q?DI+iIEtZLsysN16vbIlRE16Dx0FdiS3H+DTm5uhGMHWSU63KdloUxymR+/1v?= =?us-ascii?q?1AjvBCEpR64+1ESU9uLZfY0eFhI8r/VgLIYpGCT1PwBp2aBjR5csg2xtIfKx?= =?us-ascii?q?JhHNCKkgrE2ie7RbQSkurPTKQ5/rjbl1H1Octmg2jH3eEOg1NjWsJTPm2rne?= =?us-ascii?q?Yr+ATZQpbAj06Zmr2CbqMBxiXA626ZwCyJpk4OAyBqVqCQZXAeYkrOtdmx2U?= =?us-ascii?q?rYSKazCLk9KUMV0c6DLqpSctCvklxcQ+7+OdnEeEqqmHa2CArOzL7aP9miQH?= =?us-ascii?q?kUwCiIUBtMqAsU53vTcFFmXio=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DMBQALgsZe/yFRiNllHQEBAQEJARI?= =?us-ascii?q?BBQUBQIFHgiyBQyESLIQkiQGIBptlCwEBAQEBAQEBAQgsAQIEAQGERAKCDSc?= =?us-ascii?q?4EwIDAQEBAwIFAQEGAQEBAQEBBAQBbAQBAQcKhFEhAQMBAQUKAUOCOykBgw0?= =?us-ascii?q?BBSMzMwgDDgoCAiYCAlcGARKGJ7IygTKFUoNMgUCBDiqMUYFMP4NsNT6HYoI?= =?us-ascii?q?+IgSZM5luB4JWgQEEl00dgmKOAY0SkEmeBIFpIoFWbYM8UCWfCkIwNwIGCAE?= =?us-ascii?q?BAwl0CBOJYy2CFgEB?= X-IPAS-Result: =?us-ascii?q?A2DMBQALgsZe/yFRiNllHQEBAQEJARIBBQUBQIFHgiyBQ?= =?us-ascii?q?yESLIQkiQGIBptlCwEBAQEBAQEBAQgsAQIEAQGERAKCDSc4EwIDAQEBAwIFA?= =?us-ascii?q?QEGAQEBAQEBBAQBbAQBAQcKhFEhAQMBAQUKAUOCOykBgw0BBSMzMwgDDgoCA?= =?us-ascii?q?iYCAlcGARKGJ7IygTKFUoNMgUCBDiqMUYFMP4NsNT6HYoI+IgSZM5luB4JWg?= =?us-ascii?q?QEEl00dgmKOAY0SkEmeBIFpIoFWbYM8UCWfCkIwNwIGCAEBAwl0CBOJYy2CF?= =?us-ascii?q?gEB?= Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO md) ([217.136.81.33]) by relay.skynet.be with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 May 2020 15:32:09 +0200 Message-ID: <4719db5fbbd5f3b4026bf4b7637ce922d24e8c6b.camel@skynet.be> Subject: Re: [PATCH v2 3/3] Make exec-file-mismatch compare build IDs From: Philippe Waroquiers To: Pedro Alves , Tom Tromey , Pedro Alves via Gdb-patches Date: Thu, 21 May 2020 15:32:09 +0200 In-Reply-To: <6d669d00-236a-cede-5c5e-3d65d3ee5a53@redhat.com> References: <20200517180450.14925-1-palves@redhat.com> <20200517180450.14925-4-palves@redhat.com> <87tv0b7vy0.fsf@tromey.com> <6d669d00-236a-cede-5c5e-3d65d3ee5a53@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2020 13:32:15 -0000 On Tue, 2020-05-19 at 18:44 +0100, Pedro Alves wrote: > On 5/19/20 5:04 PM, Tom Tromey wrote: > > > > > > > "Pedro" == Pedro Alves via Gdb-patches writes: > > > > Pedro> On 5/17/20 7:04 PM, Pedro Alves via Gdb-patches wrote: > > > > The patch makes GDB first try exec-file-mismatch validation via build > > > > IDs, and then if that isn't possible, fallback to validating using the > > > > old method of comparing filenames. I'd argue that we should remove > > > > the filename validation for causing too many false positives, though. > > > > Agreed. > > > > Pedro> Here's an updated version that removes the filename comparison. > > Pedro> I've kept the structure of the code the same, in case we > > Pedro> add some form of fallback later on. > > > > It makes sense to me. > > I read these patches and they look good to me. > > Thanks all for the reviews and discussions. I've merged this now. Comparing build-id introduced a change of behaviour when GDB has loaded a file, and the user recompiles this file followed by an attach. Before this patch, when GDB had a file loaded and the user recompiled the file and attached to a process using this recompiled file, GDB used to reload the file automatically. Now, GDB reports a mismatch, indicating a "mismatch" instead of automatically re-loading the new file version. Technically, GDB mismatch is correct, but I am wondering if this change of behaviour is desirable. At least, it introduces a difference of behaviour between run (that will just indicate the file has changed and reload automatically) and attach (that will warn and ask). (gdb) atta 10615 Attaching to program: /bd/home/philippe/gdb/git/build_moreaa/gdb/gdb, process 10615 [New LWP 10616] [New LWP 10617] [New LWP 10618] [New LWP 10620] [New LWP 10621] [New LWP 10622] [New LWP 10623] warning: Mismatch between current exec-file /bd/home/philippe/gdb/git/build_moreaa/gdb/gdb and automatically determined exec-file /bd/home/philippe/gdb/git/build_moreaa/gdb/gdb exec-file-mismatch handling is currently "ask" Load new symbol table from "/bd/home/philippe/gdb/git/build_moreaa/gdb/gdb"? (y or n) while previously, GDB was doing: (gdb) atta 14099 Attaching to program: /bd/home/philippe/gdb/git/build_moreaa/gdb/gdb, process 14099 [New LWP 14100] [New LWP 14101] [New LWP 14102] [New LWP 14104] [New LWP 14105] [New LWP 14106] [New LWP 14107] `/bd/home/philippe/gdb/git/build_moreaa/gdb/gdb' has changed; re-reading symbols. Philippe