From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3qwxJyUQeWi17wcAWB0awg (envelope-from ) for ; Thu, 17 Jul 2025 11:00:53 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ZiZjY4c5; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ZiZjY4c5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 670E31E11C; Thu, 17 Jul 2025 11:00:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 623C71E089 for ; Thu, 17 Jul 2025 11:00:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 756A2385E00F for ; Thu, 17 Jul 2025 15:00:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 756A2385E00F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ZiZjY4c5; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ZiZjY4c5 Received: from AS8PR03CU001.outbound.protection.outlook.com (mail-westeuropeazlp170120005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c201::5]) by sourceware.org (Postfix) with ESMTPS id 937E73858C53 for ; Thu, 17 Jul 2025 15:00:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 937E73858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 937E73858C53 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c201::5 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1752764408; cv=pass; b=V3SjqztCi8rc3BJkCrhMYMNw1EAgttt9cOvW37nQSq4yKBp5qIJfFUEb8YKnTExbRwc0lhaZarIFdBSYNTpfgmivOujgpzf6HgocxnGFchKuz3lrxO1tQdk4KJRROwmRZ081GFzs1504M/Uk47KYW/TZRuOGaN4gU07QW9EjoQ0= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1752764408; c=relaxed/simple; bh=qaDMjPAt9/o86TNFlCZgFONNNAaY8BSMi/nKpa469lM=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=J4mrjgnDKQIQzcSnN4tunNBKSqRXH8aKVVYAe/McrI+Z8uCicsqPK8KmC/k1J2W83B2NKjLGyTLDRyZj8S+jnCqNBKWdSLBo4xsSs113IL2YND6VAMTsHmHxMr22IWk7BX4bi+dfZKQ/rGYkclpMpdAQFShhxoHefPkMRQ8pVls= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 937E73858C53 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=LFTmQDKXFDXP2KxuQ6S6DQxE5Nq8XjrYbkqySOGzTlmdVz/bEgKYRteF9UBa4ylbRqkjt8WwR5gjmVyrJOlyoDxnLA6fwreYNu5fmMucvtvRbJhyPPLY99IqNcdxop4N0ma883tdmG/qabLEh3RGl+GV/11tnweHk/KSQ0KrwhKGbfaxZceuhpB/aGg4G4fe46AOFrduop6CI9+hi1NKj3hgDymWd8hyYXehagL6AcybLSXLOl5mlE9CIOfWnxpZS1CKK3dQfXYMq67C03j9q900vfGYNg4zDZbuTgViPkSy81q1GLJI9DGoZ6iAqjDvVcC1hv/dAGKnHEgUWfP4FQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p6J6all8Kf8XkoPBPMTylW6qnIOebp+jyTKiuin/1Ig=; b=T9E/buxI5mLk6mVtceGC5mICKRlKLCkq1GdjmJWP2igSsUPbK863DEE9/swC1WeBrxAwKWR3mkTaEXaeLqNibXDwngC74NTxhKt7zzwii7FWiATPBQSX//mXSKqbn55z4ABfFGen8uGefFFikKDOLR52BWYyeehAJXhdIFsV/VIdypjOUg7AQ+OI9drBIqnp+tu4YFB4t9xZLzpX1lDobNQOWAWFgdlV4evZigXBV9IN21+3DMvNZtF03rsPFYeuLT87ceFp59GjjCfmmRbSqpQtbIboouCU/yiDZWzX7ysU0uSRrlq7UW6FwrZz3rxbNAIl4zG0wv7mZXPEWAM89g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=intel.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p6J6all8Kf8XkoPBPMTylW6qnIOebp+jyTKiuin/1Ig=; b=ZiZjY4c5OuOLGuCc//DdBvKFG0/yCci/RrRVJbCiomN2KWT2TedA37ZqZpItkC7IVuvkPm/ofMEJ0XrhVptgZGlyO0MuCuRtLRCE+JxzGUty1r0Pse4CsAgtOfKB84Dwf/08q8xvW86iuFxZeU/8YlPbqzQZ4s5vKB/A10whVcU= Received: from DU7P191CA0005.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:54e::28) by GV1PR08MB7729.eurprd08.prod.outlook.com (2603:10a6:150:50::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.39; Thu, 17 Jul 2025 15:00:05 +0000 Received: from DB1PEPF00039234.eurprd03.prod.outlook.com (2603:10a6:10:54e:cafe::cb) by DU7P191CA0005.outlook.office365.com (2603:10a6:10:54e::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8943.21 via Frontend Transport; Thu, 17 Jul 2025 15:00:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DB1PEPF00039234.mail.protection.outlook.com (10.167.8.107) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8943.21 via Frontend Transport; Thu, 17 Jul 2025 15:00:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ax0E7NYgSg/d1oWxkz1ICP4B9iZj1RUix8l92MLQvKOFIE8Uxr0MJ5PfTDJ2Sw+AD9ZaZaXn9L0fodeSu1A8UzOkrYQhBLWuwseSbFCs2PC9VCTkf3Ze/0S8vAIADY8Fhln9imDsRtQEZCS9Hh6LRdrrVoyhbQiLnlF3c0TV/X1wmlMqfzew3bKS4QfcEEMCxuzAcADGJdoAvtaQj8v2MaklCpEgPv2hKeY+A5GpPGXNDlg+lvlHL06loWGMWSuBYOBMKmfR+qF5Ew2JzL0HXhHABC/byOcYnHZK+wvn3dEfRHTFotGUSM3LXeHg1zyi2QDg0vtseKfOAKysaJB8kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p6J6all8Kf8XkoPBPMTylW6qnIOebp+jyTKiuin/1Ig=; b=ccnm+HcFUfIXbbtDKdyDBhqggLwrwsZNjYQXT5gkZ82cqJNYQTF4N5dEirM2627Uqo0rwiftTU2uXORynet1XzbdHX3lqmDpqE9VkOXU5EZwklcgxUEXx9drml8q+ID2zt3XaJ+Qv0UXahWLGqXFJIGSooE8D2+Y+JfDeXtx6ilySxHc12q84S4ZOUtSJ+uk2u4cYLqKDZeqt0DqbefUvdPZ12xGP90GoEC02l8qAJWZfZQfF4era+uD+NE4sBKZbz736RB71+Zb1vG17i6eWJ1c8+9IdqLibOe5KKNS9bOAFvqX+cWO5p0Lq27AqWO9/XsViBHHkx7YPMZSO49wUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p6J6all8Kf8XkoPBPMTylW6qnIOebp+jyTKiuin/1Ig=; b=ZiZjY4c5OuOLGuCc//DdBvKFG0/yCci/RrRVJbCiomN2KWT2TedA37ZqZpItkC7IVuvkPm/ofMEJ0XrhVptgZGlyO0MuCuRtLRCE+JxzGUty1r0Pse4CsAgtOfKB84Dwf/08q8xvW86iuFxZeU/8YlPbqzQZ4s5vKB/A10whVcU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) by PAWPR08MB10135.eurprd08.prod.outlook.com (2603:10a6:102:35a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.35; Thu, 17 Jul 2025 14:59:31 +0000 Received: from PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d]) by PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d%3]) with mapi id 15.20.8922.028; Thu, 17 Jul 2025 14:59:31 +0000 Message-ID: <47167c10-9d09-4c30-bfe5-1fc83599583e@arm.com> Date: Thu, 17 Jul 2025 15:59:31 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/12] Add CET shadow stack support Content-Language: en-US To: "Schimpe, Christina" , "gdb-patches@sourceware.org" Cc: "thiago.bauermann@linaro.org" , Andrew Burgess References: <20250628082810.332526-1-christina.schimpe@intel.com> <15bae8c2-6b3b-45b5-9b4f-f9158192fd80@arm.com> <1736d9c3-8cc6-4e00-bf5f-f824a4de0f34@arm.com> <38834676-29a4-4459-8fc7-1e59f6ad194f@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0171.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::14) To PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PR3PR08MB5852:EE_|PAWPR08MB10135:EE_|DB1PEPF00039234:EE_|GV1PR08MB7729:EE_ X-MS-Office365-Filtering-Correlation-Id: f4e1ecad-dae2-44ab-c049-08ddc5429c90 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|366016|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?aEcrc25TZXp4R3FUYTZqejZWdG5MY3NGaVNaVHBTcDlZL0pNOHZsNlBERXZi?= =?utf-8?B?enZsNHpzbTJUU0E4TWdiNHNNL0phZmxsVTE0L0Y4UGtsdVl1WWVmdDRZS2Yw?= =?utf-8?B?UXNtSU5CU0d3ZzF0TDEySWxzM09DVG0vZVFoSTk4dTFaU3VGLzN4dUJ3dFUz?= =?utf-8?B?cndzWFlNWHJtd2t6TjBhNUNxYnAva3VLaXdFa281eEFnR2dJQkY4MWc0UmND?= =?utf-8?B?SitnbFJma0Q1VEw0bVR3V2EwQmgyOVM3QlVHdHhEUlZOcXVnSHZ3ZkY3aVl5?= =?utf-8?B?b05yQmpqamx4d2hlN2hWVjFWaHBLMUJTSHVFbEszZlVkeGdPdjAwVjdDd2dy?= =?utf-8?B?MGlPSGNDV0lTQXJkL1VPUzhTcVpVaHV5RTZwdVRhMkZBT3FGUWlrcU9Vbmxm?= =?utf-8?B?SWxVWmZoVURwamNZTEFFcUlWeUJ2T21MSXNrTjI4WVA4c1V6V0owVUM2R1Iw?= =?utf-8?B?VUF4T1M5aW5FR2pFazJKNjJEQVMwS2JiZ2dMUHZzWUVLNkxCMWZGQkx1Ulh2?= =?utf-8?B?QnFaaVZoRU43Z3JvTW84aTNDQUVGaGJZK0hVc05kbm42ZEZMbFVUTUh4MDRI?= =?utf-8?B?UFFYMEhqRUZqTnp6ZWkxNWtCV0Q1MERTZlo4S2VhMzFEYXlsVnJrdTAxbmN4?= =?utf-8?B?NGRORTNwbFJpYWtub0JpK3QvUGNNd0o0aUZyY09LNExLRjAwU21DcTA3cnkr?= =?utf-8?B?V3JwMU1vYjZpQmJpVU1nYmxVbDh1SmpRcjlZbEdHckcwd1kwMnlkc210QU5a?= =?utf-8?B?c09icUJ2L2h1NXFmWW1lTWFrZTNJaGRmeXdtek5ham9jcFl4K1VnaUo3T2R0?= =?utf-8?B?T2o1RmlBUTZUZnlKTCtGNkwyWGVnSnRjeGxPYUhiWFBUTVA0VHJjVDg4MzA4?= =?utf-8?B?aW01UTdZc2tRZG9sWmIyYkN1NmtJMS9TVG5BdlBvemx0aFIzL0lDS0c5T01T?= =?utf-8?B?Sjl0VGRicjI3bEtMek94TG1UMDQ2QmtXL05hYW1OWmZSL2lNcTd2TmZOeEVX?= =?utf-8?B?YU1RMmEvTFdCRGdlM0tqc1VYU0hmL0VkbEZXbitOL0FKQkFIQ1hpU250anln?= =?utf-8?B?M3BVMG8yRThCckg2U3lvYk9ZKy9vdGhqZUlnYzZMMDVlZ3FPU2EzTU5wWlBN?= =?utf-8?B?a3c1QnBBazFubkhSamFmNVpERGhwQ3FIVFV1YWw0WHNCUnM0MkxXVGkzYStx?= =?utf-8?B?Mmk1dSsxYm9TK1IyUk9mcnA3QWJINHpub1Bzcy9ZUmN1QUdBQjZ4T2dZOFNU?= =?utf-8?B?Yld1QkwzMi9BemlBUWFOMy9EOEc3Tk54WGRwS01KaVpMMjcwTW5XZzBENjFY?= =?utf-8?B?dU9hN2dkRmlVcEJHdDNScXdTTHBkdXlud0tPRDZVZUE4VlR0a2hzYmpZSDVr?= =?utf-8?B?MWpjRjJLYUR5V0E4a29MY2tpUzY4ZENKODlYZXV4aFh3ZkFZeFo3WDN4THdw?= =?utf-8?B?dU5mcXI2NXRNZWhrYmZONzZFcTQ0OEVXMGE3L0djOTNDem1IS2lzbWNUcVRB?= =?utf-8?B?c3pBSHhSUlJOY25EUisrMzg0RVBOMDdKSnhCR1Jrbm1pb01oamp2ZXUwRE1k?= =?utf-8?B?OXd2TDBFNTdVRC8yY1hNSVUzZW45VEdKajErZFcxdEQ1Uk54NmJyNkVoQWlX?= =?utf-8?B?TTZkUFMvVS9tV2JXejNvK2dNOWJNdDZ5ODlpZDdDcko5ejRCcEszdSt2T0Fh?= =?utf-8?B?ZU50QmpLL0RRQkdKb0RBY3VaSmFzUXY5aU94YlFvQmMvOVlqMlEwa1E2Wjlp?= =?utf-8?B?aFJ6OHIzdkFTM093VXQwMHlFZFRybTVXYWdMNC9jNTk5WUk3aDdRSjlsREdx?= =?utf-8?B?TGs5QmJnY241bm5WbGdRdFN1Vi9Cd0g5Wm9tdW00VTZiTDJHSTJzYklJSHZt?= =?utf-8?B?UzlXR2IvSFdEQkJlWU14NGdDa1YrWWd2VDlZdU92U3VQcHY3ZDhQQ0hXQU5B?= =?utf-8?Q?akrIM/1ou4A=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5852.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10135 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF00039234.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 02723f0f-d4af-4427-6344-08ddc5428916 X-Microsoft-Antispam: BCL:0; ARA:13230040|14060799003|36860700013|82310400026|35042699022|376014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N2QxWTE3UjZVOHlSaXJyd0h5TnBCT0wxNDErUTVOZVVKSWxxTlQ4M25ZeXpm?= =?utf-8?B?VUJ4S1V6ajhuT3U5UUUydVRlSldhNzZkZElZTnB3ZThnUCtNQVRCeXFnQ01i?= =?utf-8?B?ZXh6SlcrUHNEWlRBTE5nTW1EaDZWY2Y1eWJIYTZWM1AyajFZZk43R2JsQmd4?= =?utf-8?B?Ukt4KzZ3RTQ0V3AwTVp0ZXpNdm50MHJuK3Ftc3ZoSEZDWFlaM1pnV01mYStj?= =?utf-8?B?ZU1GZG8za29mZTN2bEI3RmR6cGVtcVNTZHhQeGYwWHFMQklNUVF3VGxtQ0Mr?= =?utf-8?B?SkhiRkJ2eHJ4ZHk4ZTFicWUyellxZm9BR0dVZFBldW1oQU5UaU01ZmQ2NEZh?= =?utf-8?B?eFlRMDNwNklYWDlOU2FqeXg5UDNVa2MvVWFQRFBTUXVCdG9zSFRvY1hXdW1Q?= =?utf-8?B?cUR5cDZhRnZuU3pIQjc3WHE4NFlhMUxzeDhNaFhzN1ZxRERIRGFRaEdLVmQw?= =?utf-8?B?cG9uOWdJNkMzamFyQ1JHRmN0RnR6VUkxRW5CSTY1Y3JLbDlacTdFS3pMbzJE?= =?utf-8?B?SzBJQmF4aFpzY0VKaGtNcE14ZUsyNXZIUm9vVnR4dER6QlBJRHJOazFnZnFt?= =?utf-8?B?bTBFRzRzTVducWRJYkpsN2xxRFRhZE1pTVd4QUVxU1FSdC8zRDNyM0tsVllE?= =?utf-8?B?TmsxdlV0amFucGxKZllPTk9yMWFxT05MSWpBanNZTHYwUGE0VUxGNENiY3J4?= =?utf-8?B?a3dmYnpna2JqNytuMnZsNXZPdWwzZDJiUGFiMHdsQlpkRW5DcnA4R0U2Rmhj?= =?utf-8?B?ME1CWUxEcFdzTUNxMC8yc1E0NnYzM0JvTVBESUF4Uk00S2tUQVROVGF6UWVQ?= =?utf-8?B?UWhZRTFCcDNlUVgwci9DRUJvZE9UcDE0Ny9sTTE4UmhLWGpyZU4zV3dUTEpE?= =?utf-8?B?ZHI3cXpoTnc0TW9hS2RCZStTU3ZyeVBpOCtvUmwyNmk0b3I5T2EwOTArREZ0?= =?utf-8?B?Qmd5amN4RTBYcER3MEFZbUI1cnQ1dVQ2Wm1tYzJDRzNpNDhKUWhvMFhwT0sr?= =?utf-8?B?cTFxWDdxUGkwWEgwcFREa3dvMHhkVjE1Nk5VdDBWWGZ1d0JwQS9HVVFRQnZ6?= =?utf-8?B?L2dhSEhua0RmZlhoVGVxTldwR2JhTUNrdlFPTjBKS2VjSFRVTnBHZnNRcVRu?= =?utf-8?B?ZnlCRmZSUDB1WTN5NEE0bzkxTHdWWFJ3WURHSmU3NTUvRVNMTDAzdC91Yi9p?= =?utf-8?B?K2ZpN0dhUzhpUEtNSzl1d1djTkRYTWwrNEU1dklCUU51Z2FidUpxOGpsK3FR?= =?utf-8?B?TGNoTm43aG9FOXdKS0dMNTZVSVlIZWd2SStkaW1WZlliQXg0anhGOWQ5akNR?= =?utf-8?B?NWtDSXZVanR5a3hENjNPampFMCtPU3ZFL084SitUcjhDbXJqbFVzdjlHNFZT?= =?utf-8?B?cEFhM1RzbUVwQ28wT2RRbGhaTER3MW03MEViQ25pMjY2T3NucDZja0FSTHBM?= =?utf-8?B?QlhrdjBQcEtSZUFqSHJJUG52SGY1STBaRTlTVWFqdkk0MG56Rk90Z1M1VjBa?= =?utf-8?B?bnBvdHNOVzNNZGsreVNXNTFTdFFRSFU5QnY2TDJEQi9LTlEwanJBNGFGc09V?= =?utf-8?B?dmdhc0dJY0hPdVRkRldaeXNTSmxBMHRJRjFRRHhOZDFZVFpEeEd1NCtqWHd6?= =?utf-8?B?TEt2cm0zWXRuTHB2Mjd2K2FRdWNWOEcwY1pQSmZDWkJCMXByTjJSc3lNSFo1?= =?utf-8?B?NU9MbVF4NjA0UXU0MGtOazcwaEJ1enN4VWhRN1ZFSHRkc0ZkU2RESllzL1M3?= =?utf-8?B?dTBiQXptOTZwbHVFNWthOTU4eDExSXgrOWk0UUtRNjZtMmlyUDU5WjB6QWlV?= =?utf-8?B?NzdlZEYwTHlWajhEZVZMUVdHR3NtUGNSeXVzVE5MR2ZKMUp3ZjJGYVhkMjM2?= =?utf-8?B?QzgzcXZuUjZNYXYxaUZ5YUpibENUc3ZvTmNQNzJrelpDMDJmVExvWGZzKzFK?= =?utf-8?B?ZTN5Sk9rMzR4ODVqcGg4RjdweTRaZ2xOdXc0RjFZYXBWOFhRQklBSVp6a2xr?= =?utf-8?B?cS9MMGdYb3p4YU9UTDdtY1BhMUlXYUp3TXVkUGQ2bWMrTFFEMjBwbmgvbElx?= =?utf-8?Q?ld2sUQ?= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(14060799003)(36860700013)(82310400026)(35042699022)(376014)(1800799024)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2025 15:00:04.0588 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4e1ecad-dae2-44ab-c049-08ddc5429c90 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF00039234.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7729 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 7/17/25 13:01, Schimpe, Christina wrote: > Hi Luis, > > Thank you for the feedback. > >> -----Original Message----- >> From: Luis Machado >> Sent: Monday, July 14, 2025 9:13 AM >> To: Schimpe, Christina ; gdb- >> patches@sourceware.org >> Cc: thiago.bauermann@linaro.org >> Subject: Re: [PATCH v5 00/12] Add CET shadow stack support >> >> On 7/13/25 20:05, Luis Machado wrote: >>> Hi, >>> >>> On 7/13/25 15:01, Schimpe, Christina wrote: >>>> Hi Luis, >>>> >>>> Thanks for sharing that info. >>>> I tried to reproduces with the same ubuntu & kernel versions and a very >> similar system but am not successful so far... >>>> Just to be sure, I assume you test with gcc compiler (which version?) and >> compiled GDB with latest upstream master + my cet shadow stack patches? >>> >>> Interesting. GCC says: gcc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0 >>> >>> I applied the CET shadow stack patches from v5. And yes, gdb is the latest >> tip-of-tree. >>>> >>>> Do you see this for target_board=native-gdbserver and >> target_board=unix? >>> >>> No. native-gdbserver, native-extended-gdbserver and unix work just fine. >>> >>> Let me have another look to see what might be going on. >> >> Heh, found it. I had a freshly-installed system and was missing libexpat-dev, >> so no XML was being generated. >> >> With libexpat-dev installed, everything looks fine. So this is good. Sorry for >> the noise. > > No worries! > >> I spotted two things while building gdb with the patch series applied >> >> There is a uninitialized usage warning >> >> gdb/nat/x86-linux.c:151:12: warning: 'ecx' may be used uninitialized [- >> Wmaybe-uninitialized] >> 151 | if ((ecx & bit_SHSTK) == 0) >> | ~~~~~^~~~~~~~~~~~ >> ../../../repos/binutils-gdb/gdb/nat/x86-linux.c:147:26: note: 'ecx' was declared >> here >> 147 | unsigned int eax, ebx, ecx, edx; > > Yes, thank you for catching this. I'll fix it as follows: > > diff --git a/gdb/nat/x86-linux.c b/gdb/nat/x86-linux.c > index 1756d5441fc..d037992d849 100644 > --- a/gdb/nat/x86-linux.c > +++ b/gdb/nat/x86-linux.c > @@ -145,6 +145,7 @@ x86_check_ssp_support (const int tid) > stack is not enabled for the current thread, we still want to return > true. */ > unsigned int eax, ebx, ecx, edx; > + eax = ebx = ecx = edx = 0; > >> Also, git am seems to complain about some whitespace issues: >> Applying: gdb, gdbserver: Add support of Intel shadow stack pointer register. >> .git/rebase-apply/patch:596: indent with spaces. >> # Having unavailable registers leads to a fall back to the standard >> .git/rebase-apply/patch:597: indent with spaces. >> # unwinders. Don't add unavailable registers to avoid this. >> .git/rebase-apply/patch:598: indent with spaces. >> if (str (val) == ""): >> .git/rebase-apply/patch:599: indent with spaces. >> continue > > I would assume that these findings are false positives, since it's a .py file and the > idents are consistently with spaces in that file. > Is that ok? It might be. If a false positive, feel free to ignore it. > >> .git/rebase-apply/patch:587: new blank line at EOF. >> + > > Thanks! Will fix. > > I also spotted a few whitespace issues through the series: > > diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c > index 782b66f1467..a2b49730e00 100644 > --- a/gdb/amd64-linux-tdep.c > +++ b/gdb/amd64-linux-tdep.c > @@ -1981,7 +1981,7 @@ amd64_linux_shadow_stack_push (gdbarch *gdbarch, CORE_ADDR new_addr, > return; > > /* The shadow stack grows downwards. To push addresses to the stack, > - we need to decrement SSP. */ > + we need to decrement SSP. */ > const int element_size > = amd64_linux_shadow_stack_element_size_aligned (gdbarch); > const CORE_ADDR new_ssp = *ssp - element_size; > @@ -2004,7 +2004,7 @@ amd64_linux_shadow_stack_push (gdbarch *gdbarch, CORE_ADDR new_addr, > regcache_raw_write_unsigned (regcache, tdep->ssp_regnum, new_ssp); > } > > -/* Implement shadow stack pointer unwinding. For each new shadow stack > +/* Implement shadow stack pointer unwinding. For each new shadow stack > pointer check if its address is still in the shadow stack memory range. > If it's outside the range set the returned value to unavailable, > otherwise return a value containing the new shadow stack pointer. */ > diff --git a/gdb/arch/x86-linux-tdesc-features.h b/gdb/arch/x86-linux-tdesc-features.h > index d1d74e70df8..a280bf608d7 100644 > --- a/gdb/arch/x86-linux-tdesc-features.h > +++ b/gdb/arch/x86-linux-tdesc-features.h > @@ -58,7 +58,7 @@ extern int x86_linux_i386_tdesc_count (); > x86_linux_xstate_bv_mask_to_tdesc_idx) into an xstate_bv_mask > value which can then be used to create a target description. > The return mask has the same format than the state component bitmap > - and does include user and supervisor state components.*/ > + and does include user and supervisor state components. */ > > extern uint64_t x86_linux_tdesc_idx_to_xstate_bv_mask (int idx); > > diff --git a/gdb/testsuite/gdb.arch/amd64-ssp.exp b/gdb/testsuite/gdb.arch/amd64-ssp.exp > index 6ddc875b9a3..18d43065034 100644 > --- a/gdb/testsuite/gdb.arch/amd64-ssp.exp > +++ b/gdb/testsuite/gdb.arch/amd64-ssp.exp > @@ -47,4 +47,3 @@ save_vars { ::env(GLIBC_TUNABLES) } { > # configuring the shadow stack pointer. > gdb_continue_to_end > } > - > diff --git a/gdbserver/linux-i386-ipa.cc b/gdbserver/linux-i386-ipa.cc > index 1a0393d127c..beb04b7f8f6 100644 > --- a/gdbserver/linux-i386-ipa.cc > +++ b/gdbserver/linux-i386-ipa.cc > @@ -174,7 +174,7 @@ initialize_fast_tracepoint_trampoline_buffer (void) > const struct target_desc * > get_ipa_tdesc (int idx) > { > - uint64_t xstate_bv_mask = x86_linux_tdesc_idx_to_xstate_bv_mask (idx); > + uint64_t xstate_bv_mask = x86_linux_tdesc_idx_to_xstate_bv_mask (idx); > >> warning: 5 lines add whitespace errors. > > which I plan to fix locally, too. > >> >> Could you please address those locally? >> >> Otherwise... >> >> Approved-By: Luis Machado >> >> I'd give this another week in case someone has any more comments, and >> then push it. >> >> Thanks for the series. > > My plan is to address your feedback as described here and also Andrew's feedback for the v5. > So far I haven't received any feedback that would block merging this or requires a new version think, > but my plan would be to wait until middle next week. I also plan to include parts of Thiago's patch > "gdb, testsuite: Extend core_find procedure to save program output" (first patch of v5), if his series > will not be merged before mine. > > Please let me know if you have any concerns with that plan. That sounds reasonable to me.