Re: Support of gdb for Windows 64 native systems

Pedro Alves
2007-10-16T07:53:16Z

On 10/16/07, Christopher Faylor wrote:
> On Tue, Oct 16, 2007 at 06:12:31AM +0200, Eli Zaretskii wrote:
> >> Date: Tue, 16 Oct 2007 00:31:04 +0100
> >> From: Pedro Alves <pedro_alves@portugalmail.pt>
> >>
> >> How about the attached?
> >
> >I have one concern:
> >
> >> -#include <sys/procfs.h>
> >
> >Why do you unconditionally remove this include? Doesn't the Cygwin
> >build want it?
>
> Actually, I wondered about this too and meant to ask. I assume that it
> isn't really needed?
>

I did explain it upthread:
" - profs.h isn't needed anymore, since I've implemented cygwin cross-core
support a few weeks ago (in i386-cygwin-tdep.c). The include can be
unconditionally removed."

The #include was introduced in Egor's original core support patch.

sys/procfs.h:

#ifndef _SYS_PROCFS_H
#define _SYS_PROCFS_H

#include <cygwin/core_dump.h>

#endif /* _SYS_PROCFS_H */

cygwin/core_dump.h describes the structures used in Cygwin core files.

Gdb doesn't use them anymore. Instead the structures are read in
host-independent form in i386-cygwin-tdep.c:core_process_module_section.

Cheers,
Pedro Alves