From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26889 invoked by alias); 11 Oct 2007 08:55:41 -0000 Received: (qmail 26861 invoked by uid 22791); 11 Oct 2007 08:55:39 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 11 Oct 2007 08:55:33 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l9B8tSU2128676 for ; Thu, 11 Oct 2007 08:55:28 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9B8tSMM905324 for ; Thu, 11 Oct 2007 10:55:28 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9B8tRMQ025207 for ; Thu, 11 Oct 2007 10:55:28 +0200 Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-41.boeblingen.de.ibm.com [9.152.248.41]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l9B8tQaL025157 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 11 Oct 2007 10:55:27 +0200 Message-ID: <470DE4A1.4090506@de.ibm.com> Date: Thu, 11 Oct 2007 08:55:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: GDB Patches , hilfinger@gnat.com, Joel Brobecker CC: Ulrich Weigand Subject: [rfc] [06/17] Get rid of current_gdbarch in ada-lang.c Content-Type: multipart/mixed; boundary="------------030503030305080106090203" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00264.txt.bz2 This is a multi-part message in MIME format. --------------030503030305080106090203 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 355 Hi, this patch gets rid of some of the current_gdbarch's in ada-lang.c Is this ok to commit? ChangeLog: * ada-lang.c (ada_create_fundamental_type): Use objfile->gdbarch to get at the current architecture. (ada_language_arch_info): Replace current_gdbarch by gdbarch. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------030503030305080106090203 Content-Type: text/plain; name="diff-ada-lang" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-ada-lang" Content-length: 8289 diff -urpN src/gdb/ada-lang.c dev/gdb/ada-lang.c --- src/gdb/ada-lang.c 2007-09-23 18:25:03.000000000 +0200 +++ dev/gdb/ada-lang.c 2007-10-11 09:26:16.000000000 +0200 @@ -10203,7 +10203,7 @@ ada_create_fundamental_type (struct objf name "". When all the dust settles from the type reconstruction work, this should probably become an error. */ type = init_type (TYPE_CODE_INT, - gdbarch_int_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_int_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "", objfile); warning (_("internal error: no Ada fundamental type %d"), typeid); break; @@ -10229,80 +10229,80 @@ ada_create_fundamental_type (struct objf break; case FT_SHORT: type = init_type (TYPE_CODE_INT, - gdbarch_short_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_short_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "short_integer", objfile); break; case FT_SIGNED_SHORT: type = init_type (TYPE_CODE_INT, - gdbarch_short_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_short_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "short_integer", objfile); break; case FT_UNSIGNED_SHORT: type = init_type (TYPE_CODE_INT, - gdbarch_short_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_short_bit (objfile->gdbarch) / TARGET_CHAR_BIT, TYPE_FLAG_UNSIGNED, "unsigned short", objfile); break; case FT_INTEGER: type = init_type (TYPE_CODE_INT, - gdbarch_int_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_int_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "integer", objfile); break; case FT_SIGNED_INTEGER: type = init_type (TYPE_CODE_INT, - gdbarch_int_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_int_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "integer", objfile); /* FIXME -fnf */ break; case FT_UNSIGNED_INTEGER: type = init_type (TYPE_CODE_INT, - gdbarch_int_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_int_bit (objfile->gdbarch) / TARGET_CHAR_BIT, TYPE_FLAG_UNSIGNED, "unsigned int", objfile); break; case FT_LONG: type = init_type (TYPE_CODE_INT, - gdbarch_long_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_long_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "long_integer", objfile); break; case FT_SIGNED_LONG: type = init_type (TYPE_CODE_INT, - gdbarch_long_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_long_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "long_integer", objfile); break; case FT_UNSIGNED_LONG: type = init_type (TYPE_CODE_INT, - gdbarch_long_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_long_bit (objfile->gdbarch) / TARGET_CHAR_BIT, TYPE_FLAG_UNSIGNED, "unsigned long", objfile); break; case FT_LONG_LONG: type = init_type (TYPE_CODE_INT, - gdbarch_long_long_bit (current_gdbarch) + gdbarch_long_long_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "long_long_integer", objfile); break; case FT_SIGNED_LONG_LONG: type = init_type (TYPE_CODE_INT, - gdbarch_long_long_bit (current_gdbarch) + gdbarch_long_long_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "long_long_integer", objfile); break; case FT_UNSIGNED_LONG_LONG: type = init_type (TYPE_CODE_INT, - gdbarch_long_long_bit (current_gdbarch) + gdbarch_long_long_bit (objfile->gdbarch) / TARGET_CHAR_BIT, TYPE_FLAG_UNSIGNED, "unsigned long long", objfile); break; case FT_FLOAT: type = init_type (TYPE_CODE_FLT, - gdbarch_float_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_float_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "float", objfile); break; case FT_DBL_PREC_FLOAT: type = init_type (TYPE_CODE_FLT, - gdbarch_double_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_double_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "long_float", objfile); break; case FT_EXT_PREC_FLOAT: type = init_type (TYPE_CODE_FLT, - gdbarch_long_double_bit (current_gdbarch) + gdbarch_long_double_bit (objfile->gdbarch) / TARGET_CHAR_BIT, 0, "long_long_float", objfile); break; @@ -10327,24 +10327,24 @@ enum ada_primitive_types { }; static void -ada_language_arch_info (struct gdbarch *current_gdbarch, +ada_language_arch_info (struct gdbarch *gdbarch, struct language_arch_info *lai) { - const struct builtin_type *builtin = builtin_type (current_gdbarch); + const struct builtin_type *builtin = builtin_type (gdbarch); lai->primitive_type_vector - = GDBARCH_OBSTACK_CALLOC (current_gdbarch, nr_ada_primitive_types + 1, + = GDBARCH_OBSTACK_CALLOC (gdbarch, nr_ada_primitive_types + 1, struct type *); lai->primitive_type_vector [ada_primitive_type_int] = init_type (TYPE_CODE_INT, - gdbarch_int_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT, 0, "integer", (struct objfile *) NULL); lai->primitive_type_vector [ada_primitive_type_long] = init_type (TYPE_CODE_INT, - gdbarch_long_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT, 0, "long_integer", (struct objfile *) NULL); lai->primitive_type_vector [ada_primitive_type_short] = init_type (TYPE_CODE_INT, - gdbarch_short_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_short_bit (gdbarch) / TARGET_CHAR_BIT, 0, "short_integer", (struct objfile *) NULL); lai->string_char_type = lai->primitive_type_vector [ada_primitive_type_char] = @@ -10352,27 +10352,27 @@ ada_language_arch_info (struct gdbarch * 0, "character", (struct objfile *) NULL); lai->primitive_type_vector [ada_primitive_type_float] = init_type (TYPE_CODE_FLT, - gdbarch_float_bit (current_gdbarch)/ TARGET_CHAR_BIT, + gdbarch_float_bit (gdbarch)/ TARGET_CHAR_BIT, 0, "float", (struct objfile *) NULL); lai->primitive_type_vector [ada_primitive_type_double] = init_type (TYPE_CODE_FLT, - gdbarch_double_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_double_bit (gdbarch) / TARGET_CHAR_BIT, 0, "long_float", (struct objfile *) NULL); lai->primitive_type_vector [ada_primitive_type_long_long] = init_type (TYPE_CODE_INT, - gdbarch_long_long_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_long_long_bit (gdbarch) / TARGET_CHAR_BIT, 0, "long_long_integer", (struct objfile *) NULL); lai->primitive_type_vector [ada_primitive_type_long_double] = init_type (TYPE_CODE_FLT, - gdbarch_double_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_double_bit (gdbarch) / TARGET_CHAR_BIT, 0, "long_long_float", (struct objfile *) NULL); lai->primitive_type_vector [ada_primitive_type_natural] = init_type (TYPE_CODE_INT, - gdbarch_int_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT, 0, "natural", (struct objfile *) NULL); lai->primitive_type_vector [ada_primitive_type_positive] = init_type (TYPE_CODE_INT, - gdbarch_int_bit (current_gdbarch) / TARGET_CHAR_BIT, + gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT, 0, "positive", (struct objfile *) NULL); lai->primitive_type_vector [ada_primitive_type_void] = builtin->builtin_void; --------------030503030305080106090203--