From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51248-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21763 invoked by alias); 10 Oct 2007 05:14:31 -0000
Received: (qmail 21755 invoked by uid 22791); 10 Oct 2007 05:14:30 -0000
X-Spam-Check-By: sourceware.org
Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 10 Oct 2007 05:14:29 +0000
Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) 	by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id l9A5EQix253514 	for <gdb-patches@sourceware.org>; Wed, 10 Oct 2007 05:14:26 GMT
Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) 	by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9A5EPbL2105406 	for <gdb-patches@sourceware.org>; Wed, 10 Oct 2007 07:14:25 +0200
Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) 	by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9A5EPcN001747 	for <gdb-patches@sourceware.org>; Wed, 10 Oct 2007 07:14:25 +0200
Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-41.boeblingen.de.ibm.com [9.152.248.41]) 	by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l9A5EOdm001740 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); 	Wed, 10 Oct 2007 07:14:25 +0200
Message-ID: <470C5F53.1060108@de.ibm.com>
Date: Wed, 10 Oct 2007 08:09:00 -0000
From: Markus Deuling <deuling@de.ibm.com>
User-Agent: Thunderbird 2.0.0.6 (X11/20070728)
MIME-Version: 1.0
To: Ulrich Weigand <uweigand@de.ibm.com>
CC: Markus Deuling <deuling@de.ibm.com>,         GDB Patches <gdb-patches@sourceware.org>,         Joel Brobecker <brobecker@adacore.com>,         Daniel Jacobowitz <drow@false.org>,         Maxim Grigoriev <maxim@tensilica.com>
Subject: Re: [rfc] [0/8] Get rid of current_gdbarch
References: <200710091822.l99IMjMk017593@d12av02.megacenter.de.ibm.com>
In-Reply-To: <200710091822.l99IMjMk017593@d12av02.megacenter.de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00226.txt.bz2

Ulrich Weigand schrieb:
> 
> @@ -1854,10 +1856,11 @@ If you continue, the return value that y
>    if (return_value != NULL)
>      {
>        struct type *return_type = value_type (return_value);
> -      gdb_assert (gdbarch_return_value (current_gdbarch, return_type,
> +      gdb_assert (gdbarch_return_value (get_frame_arch (get_current_frame ()),
> +					return_type,
>  					NULL, NULL, NULL)
>  		  == RETURN_VALUE_REGISTER_CONVENTION);
> -      gdbarch_return_value (current_gdbarch, return_type,
> +      gdbarch_return_value (get_frame_arch (get_current_frame ()), return_type,
>  			    get_current_regcache (), NULL /*read*/,
>  			    value_contents (return_value) /*write*/);
>      }
> 
> At this point, there's no need to involve get_current_frame.  The
> routine operates on the current regcache, and should simply consult
> its architecture.

Hm, ok, thank you very much. I'll come up with another patch.


-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com