From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51237-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26822 invoked by alias); 9 Oct 2007 19:13:31 -0000
Received: (qmail 26814 invoked by uid 22791); 9 Oct 2007 19:13:30 -0000
X-Spam-Check-By: sourceware.org
Received: from hq.tensilica.com (HELO mailapp.tensilica.com) (65.205.227.29)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 Oct 2007 19:13:27 +0000
Received: from localhost ([127.0.0.1]) 	by mailapp.tensilica.com with esmtp (Exim 4.34) 	id 1IfKY4-0004bx-4k; Tue, 09 Oct 2007 12:15:20 -0700
Received: from mailapp.tensilica.com ([127.0.0.1]) 	by localhost (mailapp [127.0.0.1]) (amavisd-new, port 10024) 	with ESMTP id 16429-05; Tue, 9 Oct 2007 12:15:19 -0700 (PDT)
Received: from maxim_fc5.hq.tensilica.com ([192.168.11.68]) 	by mailapp.tensilica.com with esmtp (Exim 4.34) 	id 1IfKY3-0004br-KM; Tue, 09 Oct 2007 12:15:19 -0700
Message-ID: <470BD31F.9040107@hq.tensilica.com>
Date: Tue, 09 Oct 2007 19:50:00 -0000
From: Maxim Grigoriev <maxim@tensilica.com>
User-Agent: Thunderbird 1.5.0.9 (X11/20070102)
MIME-Version: 1.0
To: Ulrich Weigand <uweigand@de.ibm.com>
CC: Markus Deuling <deuling@de.ibm.com>,   GDB Patches <gdb-patches@sourceware.org>,  Joel Brobecker <brobecker@adacore.com>,   Daniel Jacobowitz <drow@false.org>,  Maxim Grigoriev <maxim@tensilica.com>
Subject: Re: [rfc] [0/8] Get rid of current_gdbarch
References: <200710091822.l99IMjMk017593@d12av02.megacenter.de.ibm.com>
In-Reply-To: <200710091822.l99IMjMk017593@d12av02.megacenter.de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00215.txt.bz2

>> I've checked in all of those except:
>>
>> - the xtensa-tdep.c patch (to give Maxim a chance to comment), and

I've tested xtensa-tdep.* patch. It works fine.

Getting rid of defines looks somewhat less elegant. But, I think it's 
been done for a reason.

Please, go ahead and check it in.

Thanks much for doing this.

-- Maxim


Ulrich Weigand wrote:
> Markus Deuling wrote:
>
>   
>> this is the next series of 8 mostly mechnical patches to get rid of of some trivial to replace occurences of current_gdbarch. 
>>     
>
> I've checked in all of those except:
>
> - the xtensa-tdep.c patch (to give Maxim a chance to comment), and
> - the stack.c patch, because of this:
>
> @@ -1854,10 +1856,11 @@ If you continue, the return value that y
>    if (return_value != NULL)
>      {
>        struct type *return_type = value_type (return_value);
> -      gdb_assert (gdbarch_return_value (current_gdbarch, return_type,
> +      gdb_assert (gdbarch_return_value (get_frame_arch (get_current_frame ()),
> +					return_type,
>  					NULL, NULL, NULL)
>  		  == RETURN_VALUE_REGISTER_CONVENTION);
> -      gdbarch_return_value (current_gdbarch, return_type,
> +      gdbarch_return_value (get_frame_arch (get_current_frame ()), return_type,
>  			    get_current_regcache (), NULL /*read*/,
>  			    value_contents (return_value) /*write*/);
>      }
>
> At this point, there's no need to involve get_current_frame.  The
> routine operates on the current regcache, and should simply consult
> its architecture.
>
> Thanks,
> Ulrich
>
>