From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9344 invoked by alias); 9 Oct 2007 09:10:15 -0000 Received: (qmail 9335 invoked by uid 22791); 9 Oct 2007 09:10:14 -0000 X-Spam-Check-By: sourceware.org Received: from mu-out-0910.google.com (HELO mu-out-0910.google.com) (209.85.134.191) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 Oct 2007 09:10:05 +0000 Received: by mu-out-0910.google.com with SMTP id g7so2042838muf for ; Tue, 09 Oct 2007 02:10:00 -0700 (PDT) Received: by 10.82.177.3 with SMTP id z3mr7334302bue.1191920998515; Tue, 09 Oct 2007 02:09:58 -0700 (PDT) Received: from ?78.130.29.219? ( [78.130.29.219]) by mx.google.com with ESMTPS id d27sm8606199nfh.2007.10.09.02.09.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 09 Oct 2007 02:09:52 -0700 (PDT) Message-ID: <470B453D.2050603@portugalmail.pt> Date: Tue, 09 Oct 2007 11:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Pierre Muller CC: 'Joel Brobecker' , gdb-patches@sourceware.org Subject: Re: [RFC] Stabs parsing regression from GDB 6.6 to GDB 6.6.90 References: <46F707C3.1090105@portugalmail.pt> <006101c7fe8b$70d5af70$52810e50$@u-strasbg.fr> <4053daab0709240321n40d7e3e0vc0f7d5567e990785@mail.gmail.com> <006701c7feae$fbb75850$f32608f0$@u-strasbg.fr> <46F8C1C8.7080608@portugalmail.pt> <46F9A061.2020909@portugalmail.pt> <001b01c805b5$ce7f0730$6b7d1590$@u-strasbg.fr> <20071003184156.GC4305@adacore.com> <20071003185126.GA1976@caradoc.them.org> <47040AD9.6000900@portugalmail.pt> <20071003214038.GA26617@caradoc.them.org> <47060AD9.2070701@portugalmail.pt> <470ABA35.2030407@portugalmail.pt> <001e01c80a42$6530b7b0$2f922710$@u-strasbg.fr> In-Reply-To: <001e01c80a42$6530b7b0$2f922710$@u-strasbg.fr> Content-Type: multipart/mixed; boundary="------------030402080001080700040505" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00189.txt.bz2 This is a multi-part message in MIME format. --------------030402080001080700040505 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 511 Pierre Muller wrote: > Pedro, > > you patch to main leads to a warning when compiling stabsread.o > because sign_bit might be used uninitialized. > Even though this is a false alarm, > as sign_bit is set if two_complement_representation is, > and used later only if two_complement_representation is set; > we need to correct this, as it leads to a compilation failure if > -Werror is used. > Ah, sorry and thanks. I built with -O0 only ... Checked the attached in, as obvious. -- Cheers, Pedro Alves --------------030402080001080700040505 Content-Type: text/x-diff; name="stabsread_werror.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="stabsread_werror.diff" Content-length: 619 2007-10-09 Pedro Alves * stabsread.c (read_huge_number): Initialize local variable to 0. --- gdb/stabsread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: src/gdb/stabsread.c =================================================================== --- src.orig/gdb/stabsread.c 2007-10-09 09:58:42.000000000 +0100 +++ src/gdb/stabsread.c 2007-10-09 09:58:52.000000000 +0100 @@ -3703,7 +3703,7 @@ read_huge_number (char **pp, int end, in { char *p = *pp; int sign = 1; - int sign_bit; + int sign_bit = 0; long n = 0; int radix = 10; char overflow = 0; --------------030402080001080700040505--