From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MxmzKhkvV2GjBAAAWB0awg (envelope-from ) for ; Fri, 01 Oct 2021 11:54:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 997521EDF0; Fri, 1 Oct 2021 11:54:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E0B281E813 for ; Fri, 1 Oct 2021 11:54:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA41F3857809 for ; Fri, 1 Oct 2021 15:53:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EA41F3857809 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633103640; bh=EjM7yE5WKTco3rYt/+ybslqSfTfFVbDSiBBp22+SyRc=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=XzpYH2v/QdvFSga6noX3k2xc/mCseQyQDXR9w/eACaI9+COa009hFNd9/LdNxieB6 0E/gLeT6M753essvp90sbGD3w89AtFTKDMGmHzC9/hrB5frATBLyzMg3A+YWjYWIk5 IZ64yIKnQTpAKnuTqER88zpMor+C0p7HP3Z4Tbds= Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id B72E43858025 for ; Fri, 1 Oct 2021 15:53:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B72E43858025 Received: by mail-ua1-x930.google.com with SMTP id f13so1168998uan.6 for ; Fri, 01 Oct 2021 08:53:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EjM7yE5WKTco3rYt/+ybslqSfTfFVbDSiBBp22+SyRc=; b=f3jtvCw4RvbUWK2Uwl6XPftEW1m+xvo5Cs7/uhFvQ9ETz3xcOoyZmFNKe0suuV8EqX UdDrQhraaa4Z9RvVLdtrK/VhnC1MXJTRLgACnpwOZgj7uwTkT0gVAjMbC4pH6Lo9myd2 CiOQ8fIc2nzX5M1A6XfPlzszgng1pOcAyhBN03rHb1m0YfSUBry8iUXyGhMzmCDjAGpv bJzneySxKNBNpghqT+rp2KPb6QezWL+OP0TozIJY6+s4+RJjqaZFbFJkKNadEvNCnkC/ v8L/FnKlz4BRWAD1mE9lR0OcaxykVoa1pCSAU4AP/+1LR3nexgKK+PNg7WEeaL+8fsH5 Ov+Q== X-Gm-Message-State: AOAM531ZEOLimBNb12mj/Y/l3pQOBtD22at+haLqQMiB4isEt5wsJf/p OQnOvmIfl5rbxhhKdph/+U+8dxuTzF9LtQ== X-Google-Smtp-Source: ABdhPJx+qdqQiBrD9Cyg1CPqYBAcPnrFyOjs5oqmuAeigJ40qm8j1yfRO+ZnkhCLyh6qmiCXE0AV2g== X-Received: by 2002:ab0:7254:: with SMTP id d20mr10906529uap.116.1633103617288; Fri, 01 Oct 2021 08:53:37 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:3c03:11ed:b1d3:f37e:d87b? ([2804:7f0:4841:3c03:11ed:b1d3:f37e:d87b]) by smtp.gmail.com with ESMTPSA id w194sm2282513vkh.11.2021.10.01.08.53.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 08:53:36 -0700 (PDT) Subject: Re: [PATCH] Fix build failure for 32-bit targets To: gdb-patches@sourceware.org References: <20211001115002.1681134-1-luis.machado@linaro.org> Message-ID: <46f0c972-d009-d066-bc4f-689660124b63@linaro.org> Date: Fri, 1 Oct 2021 12:53:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 10/1/21 12:25 PM, Mike Frysinger wrote: > On 01 Oct 2021 08:50, Luis Machado via Gdb-patches wrote: >> When building master GDB, I ran into the following: >> >> binutils-gdb/gdb/bt-utils.c: In function ‘int libbacktrace_print(void*, uintptr_t, const char*, int, const char*)’: >> binutils-gdb/gdb/bt-utils.c:93:44: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uintptr_t {aka unsigned int}’ [-Werror=format=] >> snprintf (buf, sizeof (buf), "0x%lx ", pc); >> >> Fix this by using phex and %s as opposed to 0x%lx. > > wouldn't PRIxPTR fix it and be simpler ? > -mike > I'm happy either way, but GDB uses phex/phex_nz/pulongest much more often. grep "phex" gdb -R | wc -l 143 grep "PRIx" gdb -R | wc -l 25