From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PXKCHmIpgmClbAAAWB0awg (envelope-from ) for ; Thu, 22 Apr 2021 21:56:50 -0400 Received: by simark.ca (Postfix, from userid 112) id 702811F104; Thu, 22 Apr 2021 21:56:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CCAA91E01F for ; Thu, 22 Apr 2021 21:56:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 74FED3857804; Fri, 23 Apr 2021 01:56:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 74FED3857804 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619143009; bh=8Fwysxbbq55hSPsKbNQ+dyvKOWefhc/EDOnNCDeRgIU=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=JdCxI/EWazUiS7S+BFL7KFFquudPX2vuUPqj7hN40XNJR8sMwbR8YezmclkENM8f9 IJ5Pe4R/OJGPaT4M3K8PBt6cmCJez0ftRBh2VjBcxYcj0lggxrUNsBEtOVm/ZparbR DjeArxE3ClJDKwGd7a7dvaS7RcG3SfCtCGCy9c/4= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7E44A3857804 for ; Fri, 23 Apr 2021 01:56:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7E44A3857804 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13N1ueFt029995 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Apr 2021 21:56:45 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13N1ueFt029995 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A2E4D1E01F; Thu, 22 Apr 2021 21:56:40 -0400 (EDT) Subject: Re: [pushed] Fix sim build failure To: Tom Tromey , gdb-patches@sourceware.org References: <20210423015107.3841223-1-tom@tromey.com> Message-ID: <46e3682d-e0e0-f6c3-07a7-a11e5b89e8d5@polymtl.ca> Date: Thu, 22 Apr 2021 21:56:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210423015107.3841223-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 23 Apr 2021 01:56:40 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-22 9:51 p.m., Tom Tromey wrote: > On x86-64 Fedora 32, the sim was failing to build. > sim_events_schedule was passing a 'dummy' argument to > sim_events_schedule_vtracef, which caused an error because the format > parameter was NULL. However, removing this dummy argument caused an > error because too few arguments were being passed -- catch 22. > > This patch fixes the build problem by using sim_events_schedule_tracef > instead. > > sim/common/ChangeLog > 2021-04-22 Tom Tromey > > * sim-events.c (sim_events_schedule): Use > sim_events_schedule_tracef. > --- > sim/common/ChangeLog | 5 +++++ > sim/common/sim-events.c | 5 +---- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/sim/common/sim-events.c b/sim/common/sim-events.c > index 207c8674d16..60e4c55a874 100644 > --- a/sim/common/sim-events.c > +++ b/sim/common/sim-events.c > @@ -469,10 +469,7 @@ sim_events_schedule (SIM_DESC sd, > sim_event_handler *handler, > void *data) > { > - va_list dummy; > - memset (&dummy, 0, sizeof dummy); > - return sim_events_schedule_vtracef (sd, delta_time, handler, data, > - NULL, dummy); > + return sim_events_schedule_tracef (sd, delta_time, handler, data, NULL); > } > #endif > > Ah, good catch. Clang doesn't give this warning, and I didn't think of building my patch with gcc, so I missed it. Using the tracef variant looks better anyway. Simon