[PATCH 3/3] gdb.base/fileio.c: Fix several -Wmaybe-uninitialized warnings

Pedro Alves
2017-05-18T11:09:10Z

src/gdb/testsuite/gdb.base/fileio.c: In function ‘test_write’:
src/gdb/testsuite/gdb.base/fileio.c:158:5: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
printf ("write 1: ret = %d, errno = %d\n", ret, errno);
^

gdb/ChangeLog:
2017-05-18 Pedro Alves <palves@redhat.com>

* gdb.base/fileio.c (test_write, test_read, test_close)
(test_fstat): Don't print 'ret' in the fail path.
---
gdb/testsuite/gdb.base/fileio.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c
index 415f2d0..7f482a3 100644
--- a/gdb/testsuite/gdb.base/fileio.c
+++ b/gdb/testsuite/gdb.base/fileio.c
@@ -157,7 +157,7 @@ test_write (void)
close (fd);
}
else
- printf ("write 1: ret = %d, errno = %d\n", ret, errno);
+ printf ("write 1: errno = %d\n", errno);
stop ();
/* Write using invalid file descriptor */
errno = 0;
@@ -177,7 +177,7 @@ test_write (void)
close (fd);
}
else
- printf ("write 3: ret = %d, errno = %d\n", ret, errno);
+ printf ("write 3: errno = %d\n", errno);
stop ();
}

@@ -203,7 +203,7 @@ test_read (void)
close (fd);
}
else
- printf ("read 1: ret = %d, errno = %d\n", ret, errno);
+ printf ("read 1: errno = %d\n", errno);
stop ();
/* Read using invalid file descriptor */
errno = 0;
@@ -271,7 +271,7 @@ test_close (void)
ret == 0 ? "OK" : "");
}
else
- printf ("close 1: ret = %d, errno = %d\n", ret, errno);
+ printf ("close 1: errno = %d\n", errno);
stop ();
/* Close an invalid file descriptor */
errno = 0;
@@ -337,7 +337,7 @@ test_fstat (void)
close (fd);
}
else
- printf ("fstat 1: ret = %d, errno = %d\n", ret, errno);
+ printf ("fstat 1: errno = %d\n", errno);
stop ();
/* Fstat using invalid file descriptor */
errno = 0;
--
2.5.5