From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id t+kaH5WIomR/cxQAWB0awg (envelope-from ) for ; Mon, 03 Jul 2023 04:36:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=xQuxJNll; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 704EE1E0BB; Mon, 3 Jul 2023 04:36:37 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5BAC11E00F for ; Mon, 3 Jul 2023 04:36:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A5DD33858023 for ; Mon, 3 Jul 2023 08:36:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A5DD33858023 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688373394; bh=CpTZ+imo2gUiIBhpnp8t52Itk3c2Q+LOtyyvhhzpw9Q=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xQuxJNllr7KHtkod155eNeoIXRJ8kJz40ZxeLRAGnqJ5SjepwJtDNAP71tGvArJkP WKq/fFQt+PDBSBunNUATGPjoPYiDbbPecPvIYhvDfJC0f+F5E9QrJ/YCQ0rXTYgOaE LCUZB49WYNGolsYexisofMOOH6I4VGJyF2/pSnqU= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 930A43858D28 for ; Mon, 3 Jul 2023 08:36:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 930A43858D28 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-A58b7JRpPIWvT25xj5VP2g-1; Mon, 03 Jul 2023 04:36:03 -0400 X-MC-Unique: A58b7JRpPIWvT25xj5VP2g-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4fb76659d44so3788485e87.3 for ; Mon, 03 Jul 2023 01:36:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688373362; x=1690965362; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CpTZ+imo2gUiIBhpnp8t52Itk3c2Q+LOtyyvhhzpw9Q=; b=lla5OKCJjO/rDqUuxdcpgV87+xQB7gyKn9Uf2PrssGMOa/W5MzprnF4YpD8joc3VqE 4BHyksAh2ylsXUGm562VuyNECBnayTQF0s5y8+kMn5Sw94FDhywLPhHB+poc5BjQjQ2R 9HrwODSbBJhYxCowz6Rn9V24WvUBbh2FAFCEE3ivuJ9al4p2mg1dBOKVDMs4FnO4ZTsm yP6rleeMjoiws1UGEjLqzn/a+ll6vYSioXkzYBCaoQIYJ1GZ8KZIfY2qUkaomVv47inT CBkl+rsjy/VNRY0mcXTWX7S74eWNh1HkjthCJGXgImUE1scdgkiKje8ewVwQffgN9/ux 9Ebw== X-Gm-Message-State: ABy/qLbAtITGPY6Z6mUa2qaKTmayGEjMbc277S6nZ3cOgEE9z7W6H9FZ xsh4zP4ZDyU9fxBt7+97phheE+QqpeHs1unxdJ09Bq88v3ilxe7/LX6aXCdqu23B7g5ziCvj5TS RSUCkhj7vbuLe1ATiqrzo4A== X-Received: by 2002:ac2:58e2:0:b0:4fb:7665:9b0d with SMTP id v2-20020ac258e2000000b004fb76659b0dmr5423732lfo.12.1688373362447; Mon, 03 Jul 2023 01:36:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlHmZ4ZdMhqZnw6fsZPLh5fgNeqyWY9dsRTdTPAVXJUlfZ/Gm02XGX3hjyaNIZl36j8L2yXocQ== X-Received: by 2002:ac2:58e2:0:b0:4fb:7665:9b0d with SMTP id v2-20020ac258e2000000b004fb76659b0dmr5423719lfo.12.1688373362099; Mon, 03 Jul 2023 01:36:02 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id s7-20020adfeb07000000b0030ae901bc54sm24841250wrn.62.2023.07.03.01.36.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 01:36:01 -0700 (PDT) Message-ID: <46cef104-95dd-3b30-5ba8-be943f52bd1e@redhat.com> Date: Mon, 3 Jul 2023 10:36:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS To: Kevin Buettner Cc: gdb-patches@sourceware.org, pedro@palves.net, aburgess@redhat.com, brobecker@adacore.com, simon.marchi@polymtl.ca, tom@tromey.com, tdevries@suse.de, ulrich.weigand@de.ibm.com, eliz@gnu.org References: <20230628124205.1604307-2-blarsen@redhat.com> <20230628124205.1604307-3-blarsen@redhat.com> <20230630140726.292b6eed@f38-zws-nv> In-Reply-To: <20230630140726.292b6eed@f38-zws-nv> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_FILL_THIS_FORM_SHORT, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Bruno Larsen via Gdb-patches Reply-To: Bruno Larsen Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 30/06/2023 23:07, Kevin Buettner wrote: > Hi, > > See my comments in-line below. > > Kevin > > On Wed, 28 Jun 2023 14:42:06 +0200 > Bruno Larsen wrote: > >> The project has been using Tested-By (tb), Reviewed-By (rb) and >> Approved-By (ab) for some time, but there has been no information to be >> found in the actual repository. This commit changes that by adding >> information about all git trailers to the MAINTAINERS file, so that it >> can be easily double-checked. >> >> The upstream discussion also brought up the use of Acked-by, which is >> better defined in this commit. Finally, for completeness sake, the >> trailers Co-Authored-By and Bug were added, even though they have been >> in use for some time already >> --- >> gdb/MAINTAINERS | 66 +++++++++++++++++++++++++++++++++++++++++++------ >> 1 file changed, 58 insertions(+), 8 deletions(-) >> >> diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS >> index 7fa608fd82c..cd9d299ea42 100644 >> --- a/gdb/MAINTAINERS >> +++ b/gdb/MAINTAINERS >> @@ -43,14 +43,9 @@ patch without review from another maintainer. This especially includes >> patches which change internal interfaces (e.g. global functions, data >> structures) or external interfaces (e.g. user, remote, MI, et cetera). >> >> -The term "review" is used in this file to describe several kinds of feedback >> -from a maintainer: approval, rejection, and requests for changes or >> -clarification with the intention of approving a revised version. Review is >> -a privilege and/or responsibility of various positions among the GDB >> -Maintainers. Of course, anyone - whether they hold a position but not the >> -relevant one for a particular patch, or are just following along on the >> -mailing lists for fun, or anything in between - may suggest changes or >> -ask questions about a patch! >> +The word "contributor" is used in this document to refer to any GDB >> +developer listed above as well as folks who may have suggested some >> +patches but aren't part of one of those categories for any reason. >> >> There's also a couple of other people who play special roles in the GDB >> community, separately from the patch process: >> @@ -78,6 +73,61 @@ consensus among the global maintainers and any other involved parties. >> In cases where consensus can not be reached, the global maintainers may >> ask the official FSF-appointed GDB maintainers for a final decision. >> >> +The term "review" is used in this file to describe several kinds of >> +feedback from a maintainer: approval, rejection, and requests for changes >> +or clarification with the intention of approving a revised version. >> +Approval is a privilege and/or responsibility of various positions among >> +the GDB Maintainers. Of course, anyone - whether they hold a position, but >> +not the relevant one for a particular patch, or are just following along on >> +the mailing lists for fun, or anything in between - may suggest changes, ask >> +questions about a patch or say if they believe a patch is fit for upstreaming! >> + >> +To ensure that patches are only pushed when approved, and to properly credit >> +the contributors who take the time to improve this project, the following >> +trailers are used to identify who contributed and how. All patches pushed >> +upstream should have at least one Approved-By patches (with the exception of >> +obvious patches, see below). The trailers (or tags) currently in use are: >> + >> + - Acked-By: >> + >> + Used when a contributor has taken a quick glance at a patch and agrees >> + with the direction outlined in the commit message, but hasn't evaluated >> + the code for correctness or regressions. >> + >> + - Tested-by: >> + >> + Used when a contributor has tested the patch and finds that it >> + fixes the claimed problem. It may also be used to indicate that >> + the contributor has performed regression testing. By itself, this >> + tag says nothing about the quality of the fix implemented by the >> + patch. >> + >> + - Reviewed-by: >> + >> + Used when a contributor has looked at code and agrees with the > s/code/the code/ fixed > >> + changes, but either doesn't have the authority or doesn't feel >> + comfortable approving the patch. >> + >> + - Approved-by: >> + >> + Used by responsible maintainers or global maintainers when a patch is >> + ready to be upstreamed. Some patches may touch multiple areas and >> + require multiple approvals before landing (such as a maintainer only >> + approving documentation), it is up to the maintainer giving the approval >> + tag to make it clear when that a tag is not sufficient. Responsible, >> + Global and Official FSF-appointed maintainers may approve their own >> + patches, but it is recommended that they seek external approval before >> + doing so. >> + >> + - Co-Authored-By: >> + >> + Used when the commit includes meaningful conrtibutions from multiple people. > For all of the above trailers/tags, I think it's worth mentioning what should follow > the ":". As I understand it, the name and email address should be specified - like > this: > > Approved-by: Jane Doe That's a good point. I added a section saying Usage: "Approved-By: Your Name " not sure if that is the best way to do it, though... > >> + >> + - Bug: >> + >> + This trailer is added with a link to the GDB bug tracker for added context > Maybe s/GDB bug tracker/GDB bug tracker bug/ ? I.e. we want to specify a link > to a specific bug, not a link to the top level for the bug tracking site. good point, I changed it > >> + on relevant commits. >> + >> >> The Obvious Fix Rule >> -------------------- >> -- >> 2.41.0 >> -- Cheers, Bruno