From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50009 invoked by alias); 6 May 2016 11:58:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50000 invoked by uid 89); 6 May 2016 11:58:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=misses, Hx-languages-length:947 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 May 2016 11:58:07 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 83CF97D0C8; Fri, 6 May 2016 11:58:06 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u46Bw575027181; Fri, 6 May 2016 07:58:05 -0400 Subject: Re: [PATCH v2 00/25] Towards great frontend GDB consoles To: Yao Qi References: <1458573675-15478-1-git-send-email-palves@redhat.com> <867fguvlq1.fsf@gmail.com> Cc: gdb-patches@sourceware.org, Marc Khouzam From: Pedro Alves Message-ID: <46bd76fe-53f4-d644-7893-14c388e56d66@redhat.com> Date: Fri, 06 May 2016 11:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <867fguvlq1.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00096.txt.bz2 On 03/22/2016 10:41 AM, Yao Qi wrote: > Pedro Alves writes: > >> This still misses ChangeLog entries, some comments, and documentation >> changes. And I haven't thought about tests yet. > > I go through the patches, and give my comments. Thanks much! > They look pretty good! > We need to think about the tests. So for v3, I added a way to run the whole testsuite with MI running in a separate UI, by passing: make check RUNTESTFLAGS="FORCE_SEPARATE_MI_TTY=1" That was quite convenient and caught a few issues, all of which I resolved for v3. In addition, I made it possible for the tests themselves to easily start with MI on a separate UI. So some of the new patches in v3 come changes to testcases to make them run with both MI running in the main UI and as separate UI. All in all, I'm pretty confident with v3 now. I'll post it soon. Thanks, Pedro Alves