Re: [PATCH 22/22] Introduce enum_flag type for ui_out flags

Simon Marchi
2016-11-30T21:32:27Z

On 2016-11-30 08:34, Pedro Alves wrote:
> On 11/24/2016 03:32 PM, Simon Marchi wrote:
>> This patch changes the ui_out flags to be an enum flag.
>
> OK.
>
>>
>> /* flags enum */
>> -enum ui_flags
>> +enum ui_out_flag
>> {
>> - ui_from_tty = 1,
>> ui_source_list = 2
>> };
>>
>> +DEF_ENUM_FLAGS_TYPE (ui_out_flag, ui_out_flags);
>
> Please add an "#include common/enum-flags.h", so the file
> includes what it needs instead of relying on indirect includes.

Good catch, I am not very good at remembering that.