From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12995 invoked by alias); 10 Sep 2007 14:11:20 -0000 Received: (qmail 12987 invoked by uid 22791); 10 Sep 2007 14:11:19 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Sep 2007 14:11:10 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.8/8.13.8) with ESMTP id l8AEB8G8161016 for ; Mon, 10 Sep 2007 14:11:08 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l8AEB7Pt1994858 for ; Mon, 10 Sep 2007 16:11:07 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l8AEB7a7016163 for ; Mon, 10 Sep 2007 16:11:07 +0200 Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l8AEB6SL016138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 10 Sep 2007 16:11:07 +0200 Message-ID: <46E5501E.9080205@de.ibm.com> Date: Mon, 10 Sep 2007 14:11:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Vladimir Prus CC: gdb-patches@sources.redhat.com Subject: Re: [0/9] Breakpoints at multiple locations References: <200709080011.13700.vladimir@codesourcery.com> <200709081831.47826.vladimir@codesourcery.com> <46E4CC11.8050502@de.ibm.com> <200709101207.17128.vladimir@codesourcery.com> In-Reply-To: <200709101207.17128.vladimir@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00135.txt.bz2 >> Vladimir Prus schrieb: >>> Once the library is unloaded, we get: >>> >>> Num Type Disp Enb Address What >>> 1 breakpoint keep y >>> breakpoint already hit 2 times >>> 1.1 y(p) 0xb7f9856d helper.hpp:4 >>> 1.2 n(p) 0xb7f98588 helper.hpp:4 >> Just an idea but for my opinion it would be great to have a hit-counter per location like: >> >> Num Type Disp Hit Enb Address What >> 1 breakpoint keep 8 y >> 1.1 5 y(p) 0xb7f9856d helper.hpp:4 >> 1.2 3 n(p) 0xb7f98588 helper.hpp:4 >> >> The entity could add up the counts of all locations. This would also get rid of the >> annoying "breakpoint already hit xy times" line :-) >> >> What do you think? > > That can possibly be interesting, but how will you handle 'ignore' > count then? Should it be per-location, too? > > I actually don't think those patches are final -- I expect some UI tweaks > to be made when this feature is more used. Hm, after a very-quick-look through breakpoint.c I see no problem in moving both ignore_count and hit_count to per-location. I guess it would make sense to let these two together and have them in a per-location way. This reflects reality best. GDB may want to set different ignore counts to different breakpoint locations and count how often a specific location was hit. Maybe thats something to come up with after the initial patch set for your multiple location breakpoints are committed. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com