From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 737 invoked by alias); 27 Aug 2007 13:01:29 -0000 Received: (qmail 32235 invoked by uid 22791); 27 Aug 2007 13:01:20 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 27 Aug 2007 13:01:12 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id l7RD19xA270848 for ; Mon, 27 Aug 2007 13:01:09 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l7RD190i2134070 for ; Mon, 27 Aug 2007 15:01:09 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l7RD18dv019909 for ; Mon, 27 Aug 2007 15:01:08 +0200 Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l7RD17ZX019853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 27 Aug 2007 15:01:08 +0200 Message-ID: <46D2CAB6.7010802@de.ibm.com> Date: Mon, 27 Aug 2007 13:01:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Daniel Jacobowitz CC: Ulrich Weigand , Jim Blandy , GDB Patches Subject: Re: [rfc] Wrap addresses in spu-gdb References: <200708201842.l7KIg16S028544@d12av02.megacenter.de.ibm.com> <46CAB6B7.30806@de.ibm.com> <20070821111432.GA19013@caradoc.them.org> In-Reply-To: <20070821111432.GA19013@caradoc.them.org> Content-Type: multipart/mixed; boundary="------------060903010103070909050006" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00483.txt.bz2 This is a multi-part message in MIME format. --------------060903010103070909050006 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 945 Hi, Daniel Jacobowitz schrieb: > >> 3) Should the used addresses in the testcase be changed to, for example, >> 0x10000 and 0x20000? This would work for SPU, too. Or shall I introduce >> variables for this addresses and set them to a range < SPU_LS_SIZE for >> SPU targets only? > > I think changing the addresses is fine. > attached is the original patch for address wrapping in SPU plus a change of the addresses in gdb.cp/cp-relocate.exp to match size of SPU Local Store. This patch showed no regression on SPU- ChangeLog gdb/: * spu-tdep.c (spu_pointer_to_address): New function. (spu_integer_to_address): Likewise. (spu_gdbarch_init): Add spu_pointer_to_address and spu_integer_to_address to gdbarch. ChangeLog gdb/testsuite/: * gdb.cp/cp-relocate.exp (add-symbol-file): Change addresses to fit into SPU Local Store memory. Is this ok ? -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------060903010103070909050006 Content-Type: text/plain; name="diff-spu-wrap-addr" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-spu-wrap-addr" Content-length: 2836 diff -urpN src/gdb/spu-tdep.c dev/gdb/spu-tdep.c --- src/gdb/spu-tdep.c 2007-08-24 04:24:10.000000000 +0200 +++ dev/gdb/spu-tdep.c 2007-08-27 13:57:37.000000000 +0200 @@ -322,6 +322,35 @@ spu_register_reggroup_p (struct gdbarch return default_register_reggroup_p (gdbarch, regnum, group); } +/* Address conversion. */ + +static CORE_ADDR +spu_pointer_to_address (struct type *type, const gdb_byte *buf) +{ + ULONGEST addr = extract_unsigned_integer (buf, TYPE_LENGTH (type)); + ULONGEST lslr = SPU_LS_SIZE - 1; /* Hard-wired LS size. */ + + if (target_has_registers && target_has_stack && target_has_memory) + lslr = get_frame_register_unsigned (get_selected_frame (NULL), + SPU_LSLR_REGNUM); + + return addr & lslr; +} + +static CORE_ADDR +spu_integer_to_address (struct gdbarch *gdbarch, + struct type *type, const gdb_byte *buf) +{ + ULONGEST addr = unpack_long (type, buf); + ULONGEST lslr = SPU_LS_SIZE - 1; /* Hard-wired LS size. */ + + if (target_has_registers && target_has_stack && target_has_memory) + lslr = get_frame_register_unsigned (get_selected_frame (NULL), + SPU_LSLR_REGNUM); + + return addr & lslr; +} + /* Decoding SPU instructions. */ @@ -2006,6 +2035,10 @@ spu_gdbarch_init (struct gdbarch_info in set_gdbarch_double_format (gdbarch, floatformats_ieee_double); set_gdbarch_long_double_format (gdbarch, floatformats_ieee_double); + /* Address conversion. */ + set_gdbarch_pointer_to_address (gdbarch, spu_pointer_to_address); + set_gdbarch_integer_to_address (gdbarch, spu_integer_to_address); + /* Inferior function calls. */ set_gdbarch_call_dummy_location (gdbarch, ON_STACK); set_gdbarch_frame_align (gdbarch, spu_frame_align); diff -urpN src/gdb/testsuite/gdb.cp/cp-relocate.exp dev/gdb/testsuite/gdb.cp/cp-relocate.exp --- src/gdb/testsuite/gdb.cp/cp-relocate.exp 2007-08-24 04:24:29.000000000 +0200 +++ dev/gdb/testsuite/gdb.cp/cp-relocate.exp 2007-08-27 13:57:37.000000000 +0200 @@ -123,7 +123,7 @@ gdb_exit gdb_start gdb_reinitialize_dir $srcdir/$subdir -gdb_test "add-symbol-file ${binfile} 0 -s ${func1_sec} 0x40000 -s ${func2_sec} 0x80000" \ +gdb_test "add-symbol-file ${binfile} 0 -s ${func1_sec} 0x10000 -s ${func2_sec} 0x20000" \ "Reading symbols from .*${testfile}\\.o\\.\\.\\.done\\.(|\r\nUsing host libthread_db library .*libthread_db.so.*\\.)" \ "add-symbol-file ${testfile}.o" \ "add symbol table from file \".*${testfile}\\.o\" at.*\\(y or n\\) " \ @@ -131,6 +131,6 @@ gdb_test "add-symbol-file ${binfile} 0 - # Make sure the function addresses were updated. gdb_test "break *'$func1_name'" \ - "Breakpoint $decimal at 0x4....: file .*" + "Breakpoint $decimal at 0x1....: file .*" gdb_test "break *'$func2_name'" \ - "Breakpoint $decimal at 0x8....: file .*" + "Breakpoint $decimal at 0x2....: file .*" --------------060903010103070909050006--