From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1138 invoked by alias); 21 Aug 2007 17:43:54 -0000 Received: (qmail 992 invoked by uid 22791); 21 Aug 2007 17:43:53 -0000 X-Spam-Check-By: sourceware.org Received: from hq.tensilica.com (HELO mailapp.tensilica.com) (65.205.227.29) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 21 Aug 2007 17:43:48 +0000 Received: from localhost ([127.0.0.1]) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1INXlX-0000Ms-5e; Tue, 21 Aug 2007 10:43:43 -0700 Received: from mailapp.tensilica.com ([127.0.0.1]) by localhost (mailapp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 31962-05; Tue, 21 Aug 2007 10:43:42 -0700 (PDT) Received: from maxim_fc5.hq.tensilica.com ([192.168.11.68]) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1INXlW-0000Mm-NU; Tue, 21 Aug 2007 10:43:42 -0700 Message-ID: <46CB2453.1090107@hq.tensilica.com> Date: Tue, 21 Aug 2007 17:43:00 -0000 From: Maxim Grigoriev User-Agent: Thunderbird 1.5.0.9 (X11/20070102) MIME-Version: 1.0 To: Nick Roberts CC: Maxim Grigoriev , gdb-patches@sources.redhat.com, Pete MacLiesh , Marc Gauthier , Ross Morley Subject: Re: [PATCH] MI and MI2 should have identical behavior on -target-download command References: <46CA01BF.3000501@hq.tensilica.com> <18122.55169.70021.143467@kahikatea.snap.net.nz> In-Reply-To: <18122.55169.70021.143467@kahikatea.snap.net.nz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00419.txt.bz2 >> What behavior do you want for mi3? I think it's reasonable to make mi2 and mi3 work similarly on -target-download. At least, until MI3 becomes a default, and GDB community comes up with a different ideas about it. I understood Daniel has the same opinion (see the follow-up email). -- Maxim Nick Roberts wrote: > > It fixes a small glitch in GDB MI. MI2 is a default. So > > MI and MI2 should work identically. The MI2 being set as > > a default is hard-coded in several places. I think one > > place was missed: > > > > mi/mi-main.c::mi_load_progress(). > > > > Without this fix, MI "-target-download" command behaves > > differently on MI versus MI2 not showing loading progress, > > when "-i=mi2" is used. > > > > GDB front-ends developers might want to stick with "-i=mi" > > assuming they always use a default. It would be a bad idea > > to force them to use explicit options like "-i=mi2". > > What behaviour do you want for mi3? > > >... > > - if (current_interp_named_p (INTERP_MI)) > > + if (current_interp_named_p (INTERP_MI) > > + || current_interp_named_p (INTERP_MI2)) > > uiout = mi_out_new (2); > > else if (current_interp_named_p (INTERP_MI1)) > > uiout = mi_out_new (1); > >