From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11416 invoked by alias); 20 Aug 2007 21:04:08 -0000 Received: (qmail 11277 invoked by uid 22791); 20 Aug 2007 21:04:07 -0000 X-Spam-Check-By: sourceware.org Received: from hq.tensilica.com (HELO mailapp.tensilica.com) (65.205.227.29) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 20 Aug 2007 21:04:03 +0000 Received: from localhost ([127.0.0.1]) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1INEPl-00077y-LS; Mon, 20 Aug 2007 14:03:57 -0700 Received: from mailapp.tensilica.com ([127.0.0.1]) by localhost (mailapp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 26832-02; Mon, 20 Aug 2007 14:03:57 -0700 (PDT) Received: from maxim_fc5.hq.tensilica.com ([192.168.11.68]) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1INEPl-00077T-0D; Mon, 20 Aug 2007 14:03:57 -0700 Message-ID: <46CA01BF.3000501@hq.tensilica.com> Date: Mon, 20 Aug 2007 21:04:00 -0000 From: Maxim Grigoriev User-Agent: Thunderbird 1.5.0.9 (X11/20070102) MIME-Version: 1.0 To: gdb-patches@sources.redhat.com, Pete MacLiesh , Marc Gauthier , Ross Morley Subject: [PATCH] MI and MI2 should have identical behavior on -target-download command Content-Type: multipart/mixed; boundary="------------000208020407060105060503" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00406.txt.bz2 This is a multi-part message in MIME format. --------------000208020407060105060503 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 603 This patch has to be approved before I can commit it. It fixes a small glitch in GDB MI. MI2 is a default. So MI and MI2 should work identically. The MI2 being set as a default is hard-coded in several places. I think one place was missed: mi/mi-main.c::mi_load_progress(). Without this fix, MI "-target-download" command behaves differently on MI versus MI2 not showing loading progress, when "-i=mi2" is used. GDB front-ends developers might want to stick with "-i=mi" assuming they always use a default. It would be a bad idea to force them to use explicit options like "-i=mi2". -- Maxim --------------000208020407060105060503 Content-Type: text/x-patch; name="mi2_default_patch.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mi2_default_patch.diff" Content-length: 785 2007-08-20 Maxim Grigoriev * mi/mi-main.c (mi_load_progress): Make MI and MI2 behave identically on -target-download command as long as MI2 is a default. Index: gdb/mi/mi-main.c =================================================================== RCS file: /cvs/src/src/gdb/mi/mi-main.c,v retrieving revision 1.101 diff -u -r1.101 mi-main.c --- gdb/mi/mi-main.c 10 Aug 2007 21:52:38 -0000 1.101 +++ gdb/mi/mi-main.c 20 Aug 2007 20:19:57 -0000 @@ -1465,7 +1465,8 @@ of this function. */ saved_uiout = uiout; - if (current_interp_named_p (INTERP_MI)) + if (current_interp_named_p (INTERP_MI) + || current_interp_named_p (INTERP_MI2)) uiout = mi_out_new (2); else if (current_interp_named_p (INTERP_MI1)) uiout = mi_out_new (1); --------------000208020407060105060503--