From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31542 invoked by alias); 20 Aug 2007 05:20:08 -0000 Received: (qmail 31438 invoked by uid 22791); 20 Aug 2007 05:20:07 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 20 Aug 2007 05:20:04 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id l7K5K1xC059456 for ; Mon, 20 Aug 2007 05:20:01 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l7K5K1Fl2121864 for ; Mon, 20 Aug 2007 07:20:01 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l7K5K1gk019267 for ; Mon, 20 Aug 2007 07:20:01 +0200 Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l7K5K00w019188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 20 Aug 2007 07:20:01 +0200 Message-ID: <46C92424.2040503@de.ibm.com> Date: Mon, 20 Aug 2007 05:20:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Ulrich Weigand , GDB Patches Subject: [Patch]: Fix sockethost handling in board config Content-Type: multipart/mixed; boundary="------------090701090706030704020302" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00386.txt.bz2 This is a multi-part message in MIME format. --------------090701090706030704020302 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 881 Hi, this patch fixes handling of gdbserver parameter in testsuite/lib/gdbserver-support.exp. When using the testsuite remotely there are two parameters possible for remote host configuration: sockethost and socketport. Currently sockethost is ignored. The format for host and port configuration is :. This patch also adds a ":" between sockethost and socketport to that it isn't needed to add it in a board configuration file anymore: # Name of the computer whose socket will be used, if required. set_board_info gdb,sockethost "localhost" # Port ID to use for socket connection set_board_info gdb,socketport "2222" Tested on x86 by running testsuite remotely. ChangeLog: * testsuite/lib/gdbserver-support.exp (gdbserver_spawn): Fix sockethost configuration. Is this ok to commit? -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------090701090706030704020302 Content-Type: text/plain; name="diff-fix-gdbsrv" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-fix-gdbsrv" Content-length: 1311 diff -urpN src/gdb/testsuite/lib/gdbserver-support.exp dev/gdb/testsuite/lib/gdbserver-support.exp --- src/gdb/testsuite/lib/gdbserver-support.exp 2007-07-03 05:52:21.000000000 +0200 +++ dev/gdb/testsuite/lib/gdbserver-support.exp 2007-08-20 06:44:45.000000000 +0200 @@ -179,10 +179,10 @@ proc gdbserver_spawn { child_args } { } # Extract the local and remote host ids from the target board struct. - if [target_info exists sockethost] { - set debughost [target_info sockethost] + if [target_info exists gdb,sockethost] { + set debughost [target_info gdb,sockethost] } else { - set debughost "localhost:" + set debughost "localhost" } # Extract the protocol @@ -195,12 +195,12 @@ proc gdbserver_spawn { child_args } { set gdbserver [find_gdbserver] # Export the host:port pair. - set gdbport $debughost$portnum + set gdbport $debughost:$portnum # Fire off the debug agent. This flavour of gdbserver takes as # arguments the port information, the name of the executable file to # be debugged, and any arguments. - set gdbserver_command "$gdbserver :$portnum $gdbserver_server_exec" + set gdbserver_command "$gdbserver $gdbport $gdbserver_server_exec" if { $child_args != "" } { append gdbserver_command " $child_args" } --------------090701090706030704020302--