Re: [Bug-readline] Re: PATCH: readline/histexpand.c, resource leak

msnyder
2007-08-18T20:15:40Z

> Jim Blandy wrote:
>> It seems to me that 'words' is a malloc'ed array of malloc'ed strings,
>> so 'free (words)' still leaks storage.
>
> I don't believe there's a case where wind == -1 and any malloced strings
> exist in words[]. There's no leak unless that can happen.

Well, that isn't locally obvious -- it depends on knowing the
behavior of other code.

You may be right -- but the free won't do any harm, and in case
you're wrong (now or in the future), the free will catch it.