From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26862 invoked by alias); 3 Aug 2007 13:03:03 -0000 Received: (qmail 26839 invoked by uid 22791); 3 Aug 2007 13:02:54 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Aug 2007 13:02:49 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.8/8.13.8) with ESMTP id l73D2kwb157392 for ; Fri, 3 Aug 2007 13:02:46 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.4) with ESMTP id l73D2kXd2273528 for ; Fri, 3 Aug 2007 15:02:46 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l73D2jnb000396 for ; Fri, 3 Aug 2007 15:02:46 +0200 Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l73D2idu000387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 3 Aug 2007 15:02:45 +0200 Message-ID: <46B3271B.1010203@de.ibm.com> Date: Fri, 03 Aug 2007 13:03:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org, uweigand@de.ibm.com Subject: Re: [rfc] [01/12] Get rid of current_gdbarch in aix-thread.c References: <46B31B17.6070204@de.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00049.txt.bz2 Hi Eli, Eli Zaretskii schrieb: >> Date: Fri, 03 Aug 2007 14:09:59 +0200 >> From: Markus Deuling >> >> this patch gets rid of some of the current_gdbarch's in aix-thread.c > > Thanks! > >> Is this ok to commit? > > I have a minor nit with the way you describe the changes in the > ChangeLog: > >> * aix-thread.c (supply_gprs64, supply_fprs, supply_sprs64) >> (supply_sprs32, fetch_regs_user_thread, fetch_regs_kernel_thread) >> (fill_gprs64, fill_gprs32, fill_fprs, fill_sprs64, fill_sprs32) >> (store_regs_user_thread, store_regs_kernel_thread): Use FRAME or >> REGCACHE to recognize current architecture. > > What are FRAME and REGCACHE here? They are not variables nor macros > seen in the patches. > sorry for being unprecise. What I meant is for example REGCACHE parameter here: static void supply_gprs64 (struct regcache *regcache, uint64_t *vals) { struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch); int regno; So current_gdbarch can be replaced by get_regcache_arch (regcache). Thanks for looking at that. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com