solib-target.c info sharedlib range addresses FIXME?

[Pedro Alves <pedro_alves@portugalmail.pt>]

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

Hi Daniel,

I was looking at this broken info sharedlibrary output on arm-wince ...

Current cvs:

(gdb) info shared
  From        To          Syms Read   Shared Object Library
(...)
0x00bc1000  0x009ab708  Yes         /cygdrive/d/Qt/qtce/qt/lib/qtguid4.dll
0x01581000  0x0025da90  Yes         /cygdrive/d/Qt/qtce/qt/lib/qtcored4.dll
0x017d1000  0x6fbc6280  Yes
/cygdrive/d/cegccsf/cegcc/cegcc/src/build-mingw32ce/mingw/mingwm10.dll
(...)

(notice that 'To < From' - visible on big libs)

... and noticed you left a commented out fix in the code.  Any
reason not to uncomment it?

Patched:

(gdb) info shared
  From        To          Syms Read   Shared Object Library
(...)
0x00bc1000  0x0155b708  Yes         /cygdrive/d/Qt/qtce/qt/lib/qtguid4.dll
0x01581000  0x017cda90  Yes         /cygdrive/d/Qt/qtce/qt/lib/qtcored4.dll
0x017d1000  0x017d6280  Yes
/cygdrive/d/cegccsf/cegcc/cegcc/src/build-mingw32ce/mingw/mingwm10.dll
(...)
(gdb)

Cheers,
Pedro Alves


[-- Attachment #2: solib_target_solib_ranges.diff --]
[-- Type: text/x-diff, Size: 757 bytes --]

	* solib-target.c (solib_target_relocate_section_addresses):
	Add orig_delta to addr_high.

---
 gdb/solib-target.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: src/gdb/solib-target.c
===================================================================
--- src.orig/gdb/solib-target.c	2007-08-02 02:15:10.000000000 +0100
+++ src/gdb/solib-target.c	2007-08-02 02:24:00.000000000 +0100
@@ -332,7 +332,8 @@ solib_target_relocate_section_addresses 
 	  so->addr_low = segment_bases[0];
 	  so->addr_high = (data->segment_bases[i - 1]
 			   + data->segment_sizes[i - 1]
-			   /* FIXME this must be needed! + orig_delta */);
+			   + orig_delta);
+	  gdb_assert (so->addr_low <= so->addr_high);
 
 	  free_symfile_segment_data (data);
 	}