From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zVbwMcVf6mgvnykAWB0awg (envelope-from ) for ; Sat, 11 Oct 2025 09:46:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1760190405; bh=xZXPwOU7rcC9BuXyFdtn04ncQ0/8Bp8kSulHT/Ob7/o=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=INRpwjyFq9HM4s19sgk0Dla6VDFIAKIgQzv3Poht6pfxyf6PIGbYj7z9wFE2W5eI0 JRGOh7I1YxLsV5rww0+y2pOF7NT/megdUTzJnpheEjTmg62oyz4uIdp6lwCnBnm34u f13XNrmCFXQIZRNXOACBc9egj/eEm2+Dpf/LnQnQ= Received: by simark.ca (Postfix, from userid 112) id BD6061E0B6; Sat, 11 Oct 2025 09:46:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=r5GD9c0r; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0A7EA1E047 for ; Sat, 11 Oct 2025 09:46:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A4B633857BA5 for ; Sat, 11 Oct 2025 13:46:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4B633857BA5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=r5GD9c0r Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6DC863857C6C for ; Sat, 11 Oct 2025 13:46:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6DC863857C6C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6DC863857C6C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760190374; cv=none; b=w5EYBw79gNQRSEqCx/RA2F8dIUGRda6s37rhYZBv8Tx7n+B+JJe7mGeoR4+683ko0HmHvg+V6EnHmxGypwzhDWW4MOSn9FzR+90SqHimHWi0GlectBnc04tYi1T9Hs9FL9/ndU27t4bQ1uzplWKJLD+pQ3N9IRA6oCYHStvgMhs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760190374; c=relaxed/simple; bh=xZXPwOU7rcC9BuXyFdtn04ncQ0/8Bp8kSulHT/Ob7/o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EPrOVECHys/bftPvSUSGrMyJbyWAYVLUuegiDF1h8TFBYFxr9IAQFKjYr6bJRY+OExnNDIe6xPm/TqcTS+oHzRgoArPkWUtPldPQbOkx27PTaR5SoBTTYREQ6qp0iZZyfoDj0TxAZB1DfsW2IHuihFoeYVGVSEhkU0KV09DSe6M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DC863857C6C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1760190374; bh=xZXPwOU7rcC9BuXyFdtn04ncQ0/8Bp8kSulHT/Ob7/o=; h=Date:Subject:To:References:From:In-Reply-To:From; b=r5GD9c0rJUkaDMThQOESdgjpy/s72x6yxQTC0ClJswm1n6CWriT+G4ANxXLa6tP6W wBBZlBfdB8dszcqoTtb7yC+LQ355S56YzsTntNTm8+pZW1MnANCKerWavcntCWvCwy hNhQpaDkdjPXXbDmfN10+IIqrcfC0HcXb8jr60+A= Received: by simark.ca (Postfix) id 2967E1E047; Sat, 11 Oct 2025 09:46:14 -0400 (EDT) Message-ID: <469655a7-2bcc-4f27-b2d7-3fa8808ca5b5@simark.ca> Date: Sat, 11 Oct 2025 09:46:13 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb/remote: replace use of std::pair with an actual struct To: Andrew Burgess , gdb-patches@sourceware.org References: <40cbbd9f0082b07e9767656fe044bbe9280983a3.1759763251.git.aburgess@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-10-11 09:34, Andrew Burgess wrote: > Commit: > > commit 5edcbe2277db05b77ebf53f9c30b6c889a8729bc > Date: Mon Jul 24 17:35:54 2023 +0100 > > gdb: detect when gdbserver has no default executable set > > Introduced a use of std::pair as a data structure to hold some per > program space information within the program space registry. > > It was pointed out during review of a later patch that the code would > be easier to understand if the std::pair was replaced with a struct > with named fields. > > That is what this commit does. Replace the std::pair with a struct, > and update all accesses to use the named fields. > > There should be no user visible changes after this commit. Thanks, this LGTM. Approved-By: Simon Marchi I would just like to point out that if we ever add more fields to this structure (this the remote target needs to record per-pspace), then it would probably make sense to rename to to "remote_per_pspace" or something like that, since it would no longer be only used to hold remote exec information. But as of now, it's correct. Simon