From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115520 invoked by alias); 27 Oct 2019 01:46:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115341 invoked by uid 89); 27 Oct 2019 01:45:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=Today, grateful, his, yours X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 27 Oct 2019 01:45:49 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B1BE71E592; Sat, 26 Oct 2019 21:45:23 -0400 (EDT) Subject: Re: [review v3] Add a string_view version of startswith To: gnutoolchain-gerrit@osci.io, Christian Biesinger , gdb-patches@sourceware.org References: <20191026231059.3779C2A07B@gnutoolchain-gerrit.osci.io> From: Simon Marchi Message-ID: <46958d8f-d8ad-ef6a-7c3f-e6ea8693d2e2@simark.ca> Date: Sun, 27 Oct 2019 01:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191026231059.3779C2A07B@gnutoolchain-gerrit.osci.io> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-10/txt/msg00942.txt.bz2 On 2019-10-26 7:10 p.m., Tom Tromey (Code Review) wrote: > Tom Tromey has posted comments on this change. > > Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/126 > ...................................................................... > > > Patch Set 3: > > Today I was working in a completely unrelated area, and it turned out I needed > this function... I wonder what would happen if I submitted your patch to gerrit > as part of another series? > > Maybe it's best not to find out. Would you mind checking this one in? If you base your patch on top of Christian's commit (d441ce34f4d2) and push for review, nothing will happen to this patch. Your new patch will just happen to have this one as a parent. If you rebase Christian's patch on master, add yours on top and push for review, then it will add a new revision to Christian's patch (assuming the permissions allow it), and create yours with this one as a parent. And Christian will be grateful to you for rebasing his patch :). I think that you should try it. For science. > -- > Gerrit-Project: binutils-gdb > Gerrit-Branch: master > Gerrit-Change-Id: I5389855de2fd70e7065a789a79374b0693651b71 > Gerrit-Change-Number: 126 > Gerrit-PatchSet: 3 > Gerrit-Owner: Christian Biesinger > Gerrit-Reviewer: Christian Biesinger > Gerrit-Reviewer: Tom Tromey > Gerrit-Comment-Date: Sat, 26 Oct 2019 23:10:58 +0000 > Gerrit-HasComments: No > Gerrit-Has-Labels: No > Gerrit-MessageType: comment >