From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32656 invoked by alias); 8 Jul 2007 14:46:09 -0000 Received: (qmail 32648 invoked by uid 22791); 8 Jul 2007 14:46:08 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.172) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 08 Jul 2007 14:46:06 +0000 Received: by ug-out-1314.google.com with SMTP id s2so1104808uge for ; Sun, 08 Jul 2007 07:46:04 -0700 (PDT) Received: by 10.78.201.15 with SMTP id y15mr1109586huf.1183905964121; Sun, 08 Jul 2007 07:46:04 -0700 (PDT) Received: from ?88.210.65.204? ( [88.210.65.204]) by mx.google.com with ESMTP id f7sm14953434nfh.2007.07.08.07.46.02 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 08 Jul 2007 07:46:03 -0700 (PDT) Message-ID: <4690F84B.9090102@portugalmail.pt> Date: Sun, 08 Jul 2007 14:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.0.12) Gecko/20070509 Thunderbird/1.5.0.12 Mnenhy/0.7.4.0 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: [rfc] DLL support for gdbserver References: <20070702221129.GD32495@caradoc.them.org> <4053daab0707040238s760df9eo4602f657a64c5582@mail.gmail.com> <46903411.8050603@portugalmail.pt> In-Reply-To: <46903411.8050603@portugalmail.pt> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00139.txt.bz2 Pedro Alves wrote: > Attached are the patches to use solib-target.c on WinCE, and a small fix to > gdbserver/win32-low.c to get toolhelp from toolhelp.dll instead > of coredll.dll - not your fault, the version I sent you had it wrong. > And testing on a different device showed up something I never noticed before. On WinCE a toolhelp snapshot is closed with CloseToolhelp32Snapshot, while on desktop Windows, one closes it with CloseHandle. It is documented as producing a leak if the wrong Close function is used, but I found it crashing on this device ... Sorry, I'm starting to hijack the thread. It would be less work for both of us to keep the patches separate. I can post the WinCE parts again in a new thread after this has gone in. Cheers, Pedro Alves