From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17205 invoked by alias); 8 Jul 2007 01:21:56 -0000 Received: (qmail 17197 invoked by uid 22791); 8 Jul 2007 01:21:55 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.172) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 08 Jul 2007 01:21:53 +0000 Received: by ug-out-1314.google.com with SMTP id s2so1039868uge for ; Sat, 07 Jul 2007 18:21:52 -0700 (PDT) Received: by 10.67.99.4 with SMTP id b4mr3907683ugm.1183857712358; Sat, 07 Jul 2007 18:21:52 -0700 (PDT) Received: from ?62.169.106.235? ( [62.169.106.235]) by mx.google.com with ESMTP id k9sm7398056nfh.2007.07.07.18.21.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 07 Jul 2007 18:21:51 -0700 (PDT) Message-ID: <46903411.8050603@portugalmail.pt> Date: Sun, 08 Jul 2007 01:21:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.0.12) Gecko/20070509 Thunderbird/1.5.0.12 Mnenhy/0.7.4.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [rfc] DLL support for gdbserver References: <20070702221129.GD32495@caradoc.them.org> <4053daab0707040238s760df9eo4602f657a64c5582@mail.gmail.com> In-Reply-To: <4053daab0707040238s760df9eo4602f657a64c5582@mail.gmail.com> Content-Type: multipart/mixed; boundary="------------080702080701030602010209" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00129.txt.bz2 This is a multi-part message in MIME format. --------------080702080701030602010209 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1053 Pedro Alves wrote: > Daniel Jacobowitz wrote: >> Here's a final version of gdbserver support for Windows DLLs. >> It works for me testing with Cygwin. Pedro, would you like to test >> this on Windows CE to see what I've broken? >> > > It looks alright, except that gdb/config/arm/wince.mt and > gdb/arm-wince-tdep.c > (to add solib-target.c, and remove the svr4 copy/paste thinko) hunks > got left out. > Testing on Windows CE didn't show up any new problems. Attached are the patches to use solib-target.c on WinCE, and a small fix to gdbserver/win32-low.c to get toolhelp from toolhelp.dll instead of coredll.dll - not your fault, the version I sent you had it wrong. I had a problem building solib-target.c that I'm reporting in another thread. gdb/ * arm-wince-tdep.c (arm_wince_init_abi): Remove svr4 related calls. * config/arm/wince.mt (TDEPFILES): Remove solib-legacy.o and solib-svr4.o, and add solib-target.o gdb/gdbserver/ * win32-low.c (load_toolhelp) [_WIN32_WCE]: Load functions from TOOLHELP.DLL. -- Cheers, Pedro Alves --------------080702080701030602010209 Content-Type: text/x-diff; name="wince_solib-target.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="wince_solib-target.diff" Content-length: 1353 * arm-wince-tdep.c (arm_wince_init_abi): Remove svr4 related calls. * config/arm/wince.mt (TDEPFILES): Remove solib-legacy.o and solib-svr4.o, and add solib-target.o --- gdb/arm-wince-tdep.c | 3 --- gdb/config/arm/wince.mt | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) Index: src/gdb/arm-wince-tdep.c =================================================================== --- src.orig/gdb/arm-wince-tdep.c 2007-07-03 20:49:54.000000000 +0100 +++ src/gdb/arm-wince-tdep.c 2007-07-04 00:56:52.000000000 +0100 @@ -55,9 +55,6 @@ arm_wince_init_abi (struct gdbarch_info /* On ARM WinCE char defaults to signed. */ set_gdbarch_char_signed (gdbarch, 1); - set_solib_svr4_fetch_link_map_offsets - (gdbarch, svr4_ilp32_fetch_link_map_offsets); - /* Shared library handling. */ set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target); Index: src/gdb/config/arm/wince.mt =================================================================== --- src.orig/gdb/config/arm/wince.mt 2007-07-03 20:49:54.000000000 +0100 +++ src/gdb/config/arm/wince.mt 2007-07-04 00:55:54.000000000 +0100 @@ -1,4 +1,4 @@ # Target: ARM based machine running Windows CE (win32) DEPRECATED_TM_FILE= tm-arm.h TDEPFILES= arm-tdep.o arm-wince-tdep.o corelow.o \ - solib.o solib-legacy.o solib-svr4.o + solib.o solib-target.o --------------080702080701030602010209 Content-Type: text/x-diff; name="gdbserver_wince.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gdbserver_wince.diff" Content-length: 679 * win32-low.c (load_toolhelp) [_WIN32_WCE]: Load functions from TOOLHELP.DLL. --- gdb/gdbserver/win32-low.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: src/gdb/gdbserver/win32-low.c =================================================================== --- src.orig/gdb/gdbserver/win32-low.c 2007-07-08 00:49:34.000000000 +0100 +++ src/gdb/gdbserver/win32-low.c 2007-07-08 00:52:44.000000000 +0100 @@ -985,7 +985,7 @@ load_toolhelp (void) #ifndef _WIN32_WCE dll = GetModuleHandle (_T("KERNEL32.DLL")); #else - dll = GetModuleHandle (_T("COREDLL.DLL")); + dll = LoadLibrary (_T("TOOLHELP.DLL")); #endif if (!dll) return FALSE; --------------080702080701030602010209--