From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20345 invoked by alias); 4 Jul 2007 03:50:07 -0000 Received: (qmail 20335 invoked by uid 22791); 4 Jul 2007 03:50:06 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 04 Jul 2007 03:50:04 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l643o18J651830 for ; Wed, 4 Jul 2007 03:50:01 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l643o0qY1343696 for ; Wed, 4 Jul 2007 05:50:00 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l643o0ee026730 for ; Wed, 4 Jul 2007 05:50:00 +0200 Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l643nwtD026655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 Jul 2007 05:50:00 +0200 Message-ID: <468B1893.5060809@de.ibm.com> Date: Wed, 04 Jul 2007 03:50:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.4 (X11/20070604) MIME-Version: 1.0 To: Ulrich Weigand CC: GDB Patches Subject: Re: [PING 2] [rfc]: Framework for looking up multiply defined global symbols in shared libraries References: <200707031217.l63CHJQg002934@d12av02.megacenter.de.ibm.com> In-Reply-To: <200707031217.l63CHJQg002934@d12av02.megacenter.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00084.txt.bz2 Ulrich Weigand schrieb: > Markus Deuling wrote: > >> * cp-namespace.c (lookup_symbol_file): Add block to >> lookup_symbol_global call. >> * Makefile.in (solist_h): Add dependency on symtab header. >> (symtab.o): Add dependency on solist header. >> * solib.c (solib_global_lookup): New function. >> * solib-svr4.c (scan_dyntag): Likewise. >> (elf_locate_base): Call helper routine scan_dyntag. >> (elf_lookup_lib_symbol): New function. >> (_initialize_svr4_solib): Add elf_lookup_lib_symbol to svr4_so_ops. >> * solist.h (symtab.h): New include. >> (lookup_lib_global_symbol): New prototype. > > I guess this should read: > (struct target_so_ops): New member lookup_lib_global_symbol. > >> (solib_global_lookup): Likewise. >> * symtab.c: New include solist.h. >> (lookup_objfile_from_block): New function. >> (lookup_global_symbol_from_objfile): New function. >> (basic_lookup_symbol_nonlocal): Add block to lookup_symbol_global call. >> (lookup_symbol_global): Call library-specific lookup procedure. >> * symtab.h (lookup_global_symbol_from_objfile): New prototype. > >> * gdb.base/libmd.c: New file (testcase multiple symbol lookup). >> * gdb.base/libmd.h: Likewise. >> * gdb.base/solib_symbol.c: Likewise. >> * gdb.base/solib_symbol.exp: Likewise. > > And those file names have changed in the latest version: > * gdb.base/solib-symbol.exp: New file (testcase multiple symbol lookup). > * gdb.base/solib-symbol-lib.c: Likewise. > * gdb.base/solib-symbol-main.c: Likewise. > > I've committed the patch with the above ChangeLog changes now. > > Thanks, > Ulrich > Thank you very much. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com