From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20811 invoked by alias); 26 Jun 2007 17:55:31 -0000 Received: (qmail 20797 invoked by uid 22791); 26 Jun 2007 17:55:30 -0000 X-Spam-Check-By: sourceware.org Received: from dessent.net (HELO dessent.net) (69.60.119.225) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 26 Jun 2007 17:55:27 +0000 Received: from localhost ([127.0.0.1] helo=dessent.net) by dessent.net with esmtp (Exim 4.50) id 1I3FG5-0003A5-Ol; Tue, 26 Jun 2007 17:55:21 +0000 Message-ID: <46815309.331600D9@dessent.net> Date: Tue, 26 Jun 2007 18:30:00 -0000 From: Brian Dessent Reply-To: insight@sourceware.org X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U) MIME-Version: 1.0 To: Ulrich Weigand CC: gdb-patches@sourceware.org, insight@sourceware.org Subject: Re: [3/3] Remove deprecated_register_gdbarch_swap infrastructure References: <200706221254.l5MCsd9w028238@d12av02.megacenter.de.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00466.txt.bz2 Ulrich Weigand wrote: > I've now committed the following version of this patch. > > Bye, > Ulrich > > * gdbarch.sh (gdbarch_swap_ftype, deprecated_register_gdbarch_swap, > DEPRECATED_REGISTER_GDBARCH_SWAP): Remove. > (struct gdbarch_swap, struct gdbarch_swap_registration, > struct gdbarch_swap_registry, gdbarch_swap_registry, > current_gdbarch_swap_init_hack, current_gdbarch_swap_out_hack, > current_gdbarch_swap_in_hack): Remove. > (find_arch_by_info): Do not call current_gdbarch_swap_init_hack. > (gdbarch_find_by_info): Do not call current_gdbarch_swap_in_hack > and current_gdbarch_swap_out_hack, update current_gdbarch directly. > (deprecated_current_gdbarch_select_hack): Likewise. > * gdbarch.h, gdbarch.c: Regenerate. Insight is still a user of deprecated_register_gdbarch_swap, so now it's broken. What's the proper replacement for the following - int Gdbtk_Register_Init (Tcl_Interp *interp) { Tcl_CreateObjCommand (interp, "gdb_reginfo", gdbtk_call_wrapper, gdb_register_info, NULL); /* Register/initialize any architecture specific data */ setup_architecture_data (); deprecated_register_gdbarch_swap (&old_regs, sizeof (old_regs), NULL); deprecated_register_gdbarch_swap (®format, sizeof (regformat), NULL); deprecated_register_gdbarch_swap (®type, sizeof (regtype), NULL); deprecated_register_gdbarch_swap (NULL, 0, setup_architecture_data); return TCL_OK; } Brian