From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14245 invoked by alias); 22 Jun 2007 09:30:42 -0000 Received: (qmail 14237 invoked by uid 22791); 22 Jun 2007 09:30:41 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 22 Jun 2007 09:30:39 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5M9UaL6143828 for ; Fri, 22 Jun 2007 09:30:36 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5M9UaWv807104 for ; Fri, 22 Jun 2007 11:30:36 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5M9Uaba002227 for ; Fri, 22 Jun 2007 11:30:36 +0200 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l5M9UOb3032678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Jun 2007 11:30:36 +0200 Message-ID: <467B9637.4000409@de.ibm.com> Date: Fri, 22 Jun 2007 09:30:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: GDB Patches CC: Ulrich Weigand , Mark Kettenis Subject: [rfc] Remove dead code in breakpoint.c Content-Type: multipart/mixed; boundary="------------000609020909030001070800" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00417.txt.bz2 This is a multi-part message in MIME format. --------------000609020909030001070800 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 521 Hello, there is no place where DISABLE_UNSETTABLE_BREAK macro is defined. So I guess the code in breakpoint.c is dead code. But I'm not sure about this- Is there a situation where the removed code is used? If so please ignore that patch. ChangeLog: * breakpoint.c (insert_bp_location): Remove dead code (DISABLE_UNSETTABLE_BREAK). (disable_breakpoints_in_shlibs) (disable_breakpoints_in_unloaded_shlib): Likewise (comment). Is this ok ? -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------000609020909030001070800 Content-Type: text/plain; name="diff-DISABLE_UNSETTABLE_BREAK" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-DISABLE_UNSETTABLE_BREAK" Content-length: 1028 diff -urN src/gdb/breakpoint.c dev/gdb/breakpoint.c --- src/gdb/breakpoint.c 2007-06-13 20:02:38.000000000 +0200 +++ dev/gdb/breakpoint.c 2007-06-22 10:04:16.000000000 +0200 @@ -963,13 +963,7 @@ if (val) { /* Can't set the breakpoint. */ - if ( -#if defined (DISABLE_UNSETTABLE_BREAK) - DISABLE_UNSETTABLE_BREAK (bpt->address) -#else - solib_address (bpt->address) -#endif - ) + if (solib_address (bpt->address)) { /* See also: disable_breakpoints_in_shlibs. */ val = 0; @@ -4488,7 +4482,6 @@ struct breakpoint *b; int disabled_shlib_breaks = 0; - /* See also: insert_breakpoints, under DISABLE_UNSETTABLE_BREAK. */ ALL_BREAKPOINTS (b) { if (((b->type == bp_breakpoint) || (b->type == bp_hardware_breakpoint)) @@ -4524,7 +4517,6 @@ struct breakpoint *b; int disabled_shlib_breaks = 0; - /* See also: insert_breakpoints, under DISABLE_UNSETTABLE_BREAK. */ ALL_BREAKPOINTS (b) { if ((b->loc->loc_type == bp_loc_hardware_breakpoint --------------000609020909030001070800--