From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 33D593858D34
 for <gdb-patches@sourceware.org>; Wed, 15 Jul 2020 03:03:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 33D593858D34
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 878E61E5F9;
 Tue, 14 Jul 2020 23:03:26 -0400 (EDT)
Subject: Re: [PATCH v3 3/3] arc: Add GNU/Linux support for ARC
To: Shahab Vahedi <shahab.vahedi@gmail.com>, gdb-patches@sourceware.org
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>,
 Francois Bedard <fbedard@synopsys.com>, Shahab Vahedi <shahab@synopsys.com>,
 Tom Tromey <tom@tromey.com>
References: <20200428160437.1585-1-shahab.vahedi@gmail.com>
 <20200713154527.13430-1-shahab.vahedi@gmail.com>
 <20200713154527.13430-4-shahab.vahedi@gmail.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <4677ac24-2fc2-8cd3-815f-513c2a5b3ee9@simark.ca>
Date: Tue, 14 Jul 2020 23:03:24 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200713154527.13430-4-shahab.vahedi@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_STOCKGEN, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2020 03:03:28 -0000

LGTM, with two nits below.

> +/* Implement the "skip_solib_resolver" gdbarch method.
> +
> +   See glibc_skip_solib_resolver for details.  */
> +
> +static CORE_ADDR
> +arc_linux_skip_solib_resolver (struct gdbarch *gdbarch, CORE_ADDR pc)
> +{
> +  /* For uClibc 0.9.26+.
> +
> +     An unresolved PLT entry points to "__dl_linux_resolve", which calls
> +     "_dl_linux_resolver" to do the resolving and then eventually jumps to
> +     the function.
> +
> +     So we look for the symbol `_dl_linux_resolver', and if we are there,
> +     gdb sets a breakpoint at the return address, and continues.  */
> +  struct bound_minimal_symbol resolver =
> +    lookup_minimal_symbol ("_dl_linux_resolver", NULL, NULL);
> +
> +  if (arc_debug)
> +    {
> +      if (resolver.minsym)

!= nullptr

> +	{
> +	  CORE_ADDR res_addr = BMSYMBOL_VALUE_ADDRESS (resolver);
> +	  debug_printf ("arc-linux: skip_solib_resolver (): "
> +			"pc = %s, resolver at %s\n",
> +			print_core_address (gdbarch, pc),
> +			print_core_address (gdbarch, res_addr));
> +	}
> +      else
> +	{
> +	  debug_printf ("arc-linux: skip_solib_resolver (): "
> +			"pc = %s, no resolver found\n",
> +			print_core_address (gdbarch, pc));
> +	}
> +    }
> +
> +  if (resolver.minsym && BMSYMBOL_VALUE_ADDRESS (resolver) == pc)

!= nullptr

Simon