From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30563 invoked by alias); 18 Jun 2007 21:54:07 -0000 Received: (qmail 30554 invoked by uid 22791); 18 Jun 2007 21:54:06 -0000 X-Spam-Check-By: sourceware.org Received: from elrond.portugalmail.pt (HELO elrond.portugalmail.pt) (195.245.179.181) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 18 Jun 2007 21:54:04 +0000 Received: from localhost (localhost [127.0.0.1]) by elrond.portugalmail.pt (Postfix) with ESMTP id 741D152E6B; Mon, 18 Jun 2007 22:54:02 +0100 (WEST) Received: from elrond.portugalmail.pt ([127.0.0.1]) by localhost (elrond.portugalmail.pt [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HwpGtzQvUDVU; Mon, 18 Jun 2007 22:54:02 +0100 (WEST) Received: from [127.0.0.1] (88.210.69.0.rev.optimus.pt [88.210.69.0]) (Authenticated sender: pedro_alves@portugalmail.pt) by elrond.portugalmail.pt (Postfix) with ESMTP id 31EA35307D; Mon, 18 Jun 2007 22:53:58 +0100 (WEST) Message-ID: <4676FEEC.2010008@portugalmail.pt> Date: Mon, 18 Jun 2007 21:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.0.12) Gecko/20070509 Thunderbird/1.5.0.12 Mnenhy/0.7.4.0 MIME-Version: 1.0 To: Ulrich Weigand , gdb-patches@sourceware.org Subject: Re: For example only, updated Windows DLL support and gdbserver DLL support References: <20070618150816.GA24037@caradoc.them.org> <20070618210728.GB1813@ednor> <20070618211213.GA1110@caradoc.them.org> In-Reply-To: <20070618211213.GA1110@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 000750-1, 18-06-2007), Outbound message X-Antivirus-Status: Clean X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00355.txt.bz2 Daniel Jacobowitz wrote: > On Mon, Jun 18, 2007 at 05:07:28PM -0400, Christopher Faylor wrote: >> I have no objections to this with two exceptions: >> >> - You use #ifdef __CYGWIN__ . That would be the only place in the file >> where that is used. I don't see any reason for this unless your patch >> is also going to allow native Windows support. If that is the case, >> then maybe that part should be provided separately. >> >> - You seemed to have gratuitously pulled out the code which deals with >> cygwin exceptions into a separate function. I don't think this has >> anything to do with solibs and probably shouldn't be part of any >> final patch. > > Pedro, what do you remember about these? At least, I don't _think_ it > was me... > Guilty as charged. The __CYGWIN__ came from copy/pasting from the gdbserver side of the patch, where it is needed. It can be easily removed. The gratuitousness is only apparent. Notice that the cygwin_load_start/cygwin_load_end calculation moved from the old solib_symbols_add into that new ignore_access_violation_p function and now uses the master_so_list () to get at cygwin1.dll. As I was touching the code, (and I was finding myself reindenting that big comment, ) I thought of moving it out of handle_exception to make it cleaner. Cheers, Pedro Alves