Ulrich Weigand wrote: > Mark Kettenis wrote: >>> Date: Wed, 13 Jun 2007 21:19:11 +0200 >>> From: Markus Deuling >>> >>> Hello, >>> >>> this patch removes DEPRECATED_EXTRACT_STRUCT_VALUE_ADDRES from gdbarch.sh. This macro hasn't been >>> used anywhere anymore. Build and tested on x86. >>> >>> ChangeLog: >>> * gdbarch.sh (DEPRECATED_EXTRACT_STRUCT_VALUE_ADDRES): Remove. >>> * gdbarch.c, gdbarch.h: Regenerate. >>> >>> Is this ok to commit ? >> Last time I looked, there was still stuff using this. Are you sure? > > There is no *caller* of this gdbarch callback left anywhere. > > However, a number of targets (sh/sh64/frv/ia64) still install this > callback. Those functions are all dead code now, and should be > removed as well. > > Bye, > Ulrich > I also removed the remaining callbacks from the targets. ChangeLog: * gdbarch.sh (DEPRECATED_EXTRACT_STRUCT_VALUE_ADDRESS): Remove. * sh-tdep.c (sh_extract_struct_value_address): Remove. (sh_gdbarch_init): Remove set_gdbarch_deprecated_extract_struct_value_address. * sh64-tdep.c (sh64_extract_struct_value_address): Remove. (sh64_gdbarch_init): Remove set_gdbarch_deprecated_extract_struct_value_address. * ia64-tdep.c (ia64_extract_struct_value_address): Remove. (ia64_gdbarch_init): Remove set_gdbarch_deprecated_extract_struct_value_address. * frv-tdep.c (frv_extract_struct_value_address): Remove. (frv_gdbarch_init): Remove set_gdbarch_deprecated_extract_struct_value_address. * gdbarch.c, gdbarch.h: Regenerate. Is this ok to commit ? -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com