From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5534 invoked by alias); 13 Jun 2007 19:35:19 -0000 Received: (qmail 5525 invoked by uid 22791); 13 Jun 2007 19:35:18 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 13 Jun 2007 19:35:12 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5DJZ7H4139402 for ; Wed, 13 Jun 2007 19:35:07 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5DJZ7kU3866870 for ; Wed, 13 Jun 2007 21:35:07 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5DJZ5Hj023769 for ; Wed, 13 Jun 2007 21:35:06 +0200 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l5DJZ4to023762 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Jun 2007 21:35:05 +0200 Message-ID: <46704697.20004@de.ibm.com> Date: Wed, 13 Jun 2007 19:35:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: Daniel Jacobowitz , GDB Patches CC: Ulrich Weigand Subject: Re: [ref] Remove macro DEPRECATED_REG_STRUCT_HAS_ADDR References: <467037D0.2060804@de.ibm.com> <20070613191958.GG31221@caradoc.them.org> <4670448A.3020804@de.ibm.com> <20070613193231.GA4962@caradoc.them.org> In-Reply-To: <20070613193231.GA4962@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00272.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Jun 13, 2007 at 09:24:58PM +0200, Markus Deuling wrote: >> Daniel Jacobowitz wrote: >>> On Wed, Jun 13, 2007 at 08:30:40PM +0200, Markus Deuling wrote: >>>> Hello, >>>> >>>> this patch completely removes DEPRECATED_REG_STRUCT_HAS_ADDR. This was only >>>> used in infcall.c >>>> and was replaced by gdbarch_stabs_argument_has_addr. Build and tested on x86. >>>> Testsuite showed no regressions. >>> There's a caller to this function in cris-tdep.c! >>> Also, there's platforms (the SPARC) which already set >>> stabs_argument_has_addr. But they don't check it in infcall.c. >>> So is that right? >> Hm, please point me to the correct file. I don't see >> DEPRECATED_REG_STRUCT_HAS_ADDR in cris-tdep.c :-( >> What do I oversee ? > > This: > > set_gdbarch_deprecated_reg_struct_has_addr (gdbarch, > cris_reg_struct_has_addr); > > I am not convinced that gdbarch_stabs_argument_has_addr is the > same thing. > Argh, silly me. I've overseen this ! Let me rework the patch.... -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com