Hi Ulrich,

Ulrich Weigand wrote:
> Markus Deuling wrote:
> 
>> this patch removes REGISTER_NAME macro from gdbarch.sh
> 
> Look good except for some minor formatting issues:
> 
> 	* sh64-tdep.c (sh64_do_fp_register,sh64_do_register)
> Should have space after comma (throughout the ChangeLog).
> 
> 
> +  if (gdbarch_register_name (current_gdbarch, regnum) == NULL
> +      || *gdbarch_register_name (current_gdbarch, (regnum)) == '\0')
> Parentheses around "regnum" are unnecessary.
> 
> +				    gdbarch_register_name
> +				    (current_gdbarch, argreg),
> I think convention is to indent the argument list by two space
> if it starts completely on a new line ...
> 
> +		       gdbarch_register_name (current_gdbarch,
> +		       DWARF2_REG_TO_REGNUM(reg)),
> Indentation is quite odd here...
> 
> +      gdb_assert (gdbarch_register_name (current_gdbarch,
> +		  VALUE_REGNUM (lazy_value)) != NULL
> +		  && *gdbarch_register_name
> +		  (current_gdbarch, VALUE_REGNUM (lazy_value)) != '\0');
> And here.
> 
> +      print_spaces_filtered (15 - strlen (gdbarch_register_name
> +					  (current_gdbarch,i)), file);
> Indentation.  Space after comma.
>  
> +	    ui_out_field_string (uiout, NULL,
> +				 gdbarch_register_name
> +				 (current_gdbarch, regnum));
> Indentation.
> 
> +  fprintf_filtered (file, "%*s", 4 - (int) strlen (gdbarch_register_name
> +						   (current_gdbarch, regnum)),
> Indentation.
> 
> +  if (gdbarch_register_name (current_gdbarch,
> +			     gdbarch_num_regs (current_gdbarch) + regnum)
> +      != NULL
> +      && gdbarch_register_name (current_gdbarch,
> +			        gdbarch_num_regs (current_gdbarch) + regnum)[0]
> +      != '\0')
> Indentation
> 
>  	  frame_register_read (frame, regnum, buff);
>  
> +  fputs_filtered (gdbarch_register_name (current_gdbarch, regnum), file);
> +  print_spaces_filtered (15 - strlen (gdbarch_register_name
> +				     (current_gdbarch, regnum)), file);
> Indentation.
> 
> +  fputs_filtered (gdbarch_register_name (current_gdbarch, regnum), file);
> +  print_spaces_filtered (15 - strlen (gdbarch_register_name
> +				      (current_gdbarch, regnum)), file);
> Again.
> 
> +    fprintf_unfiltered (gdb_stdlog, "(%s)", gdbarch_register_name
> +					    (current_gdbarch, regno));
> Again.
> 
> +			       gdbarch_register_name
> +			       (current_gdbarch, SYMBOL_VALUE (sym)));
> Again.
> 
> +			       gdbarch_register_name
> +			       (current_gdbarch, SYMBOL_VALUE (sym)));
> Again.
> 
> +			       gdbarch_register_name
> +			       (current_gdbarch, SYMBOL_VALUE (sym)));
> Again.
> 
> +			       gdbarch_register_name
> +			       (current_gdbarch, SYMBOL_BASEREG (sym)));
> Again.
> 
> +			       gdbarch_register_name
> +			       (current_gdbarch, SYMBOL_BASEREG (sym)));
> Again.
> 
> 
> Bye,
> Ulrich
> 

thank you very much for your review. I attached a patch that addresses those points.

Ok to commit?

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com