From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21357 invoked by alias); 31 May 2007 21:03:32 -0000 Received: (qmail 21349 invoked by uid 22791); 31 May 2007 21:03:32 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 31 May 2007 21:03:30 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l4VL3R4X494290 for ; Thu, 31 May 2007 21:03:27 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4VL3RLd3399754 for ; Thu, 31 May 2007 23:03:27 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4VL3Q18009044 for ; Thu, 31 May 2007 23:03:27 +0200 Received: from [9.145.148.253] (sig-9-145-148-253.de.ibm.com [9.145.148.253]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l4VL3NLg009029 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 31 May 2007 23:03:26 +0200 Message-ID: <465F37CA.1020708@de.ibm.com> Date: Thu, 31 May 2007 21:07:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: Ulrich Weigand CC: GDB Patches Subject: Re: [rfc] [2/6] Remove macro TARGET_BYTE_ORDER References: <200705312100.l4VL0VN9007416@d12av02.megacenter.de.ibm.com> In-Reply-To: <200705312100.l4VL0VN9007416@d12av02.megacenter.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00444.txt.bz2 Ulrich Weigand wrote: > Markus Deuling wrote: > >> it seems that the TARGET_BYTE_ORDER patch was missing some pieces, so that not all >> appearance of it were replaced. So here is "the rest" of the patch. I run gdb_mbuild.sh >> and let it build all targets. They were build cleanly. Sorry for the inconvenience. > > Sorry, I didn't notice this either when committing that patch. Thanks for the fix! > >> * xtensa-tdep.c (XTENSA_IS_ENTRY,extract_call_winsize) >> (xtensa_register_write_masked,xtensa_register_read_masked) <..> >> * coffread.c (process_coff_symbol): Likewise. >> * arm-tdep.c (convert_from_extended,convert_to_extended) >> (gdb_print_insn_arm): Likewise. > > You should have a space after each comma. Also, this line: > >> diff -urN src/gdb/mips-linux-tdep.c dev/gdb/mips-linux-tdep.c >> --- src/gdb/mips-linux-tdep.c 2007-05-31 19:31:37.000000000 +0200 >> +++ dev/gdb/mips-linux-tdep.c 2007-05-31 21:09:14.000000000 +0200 >> @@ -852,7 +854,7 @@ >> layout, since we can't tell, and it's much more common. Which bits are >> the "high" bits depends on endianness. */ >> for (ireg = 0; ireg < 32; ireg++) >> - if ((TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) != (ireg & 1)) >> + if (gdarch_byte_order (current_gdbarch) == BFD_ENDIAN_BIG) != (ireg & 1) > > needs to read: > if ((gdbarch_byte_order (current_gdbarch) == BFD_ENDIAN_BIG) != (ireg & 1)) > > > The rest looks OK, I've committed the patch with those two changes now. > Thank you very much. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com