Jim Blandy wrote:
>>
>> Is this ok to commit?
> 
> Yes, once the copyright assignment has been straightened out and the
> following cosmetic problems fixed:
> 
>> @@ -3362,7 +3407,7 @@
>>  	  if (mips_debug)
>>  	    fprintf_unfiltered (gdb_stderr, "Return float struct+%d\n",
>>  				offset);
>> -	  mips_xfer_register (regcache, NUM_REGS + regnum,
>> +	  mips_xfer_register (regcache, gdbarch_num_regs (current_gdbarch) + regnum,
>>  			      TYPE_LENGTH (TYPE_FIELD_TYPE (type, field)),
>>  			      TARGET_BYTE_ORDER, readbuf, writebuf, offset);
>>  	}
> 
> Lines in GDB are supposed to fit in eighty columns.
> 
>> @@ -3388,7 +3433,7 @@
>>  	  if (mips_debug)
>>  	    fprintf_unfiltered (gdb_stderr, "Return struct+%d:%d in $%d\n",
>>  				offset, xfer, regnum);
>> -	  mips_xfer_register (regcache, NUM_REGS + regnum, xfer,
>> +	  mips_xfer_register (regcache, gdbarch_num_regs (current_gdbarch) + regnum, xfer,
>>  			      BFD_ENDIAN_UNKNOWN, readbuf, writebuf, offset);
>>  	}
>>        return RETURN_VALUE_REGISTER_CONVENTION;
> 
> Same here.
> 

Again thank you very much. Attached is the new version of the patch.

Ulrich, could you please commit it? Thank you.


-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com