From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12236 invoked by alias); 29 May 2007 07:22:07 -0000 Received: (qmail 12209 invoked by uid 22791); 29 May 2007 07:22:06 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 May 2007 07:22:04 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id l4T7M1vF151756 for ; Tue, 29 May 2007 07:22:01 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4T7M15H3788814 for ; Tue, 29 May 2007 09:22:01 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4T7M10C023253 for ; Tue, 29 May 2007 09:22:01 +0200 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l4T7LxC9023229 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 May 2007 09:22:01 +0200 Message-ID: <465BD448.5030003@de.ibm.com> Date: Tue, 29 May 2007 07:22:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: GDB Patches CC: Ulrich Weigand Subject: [rfc] [3/6] Remove macro TARGET_CHAR_SIGNED Content-Type: multipart/mixed; boundary="------------000401010508090706060102" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00415.txt.bz2 This is a multi-part message in MIME format. --------------000401010508090706060102 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 367 Hello, this patch removes TARGET_CHAR_SIGNED macro from gdbarch.sh. ChangeLog: * gdbarch.sh (TARGET_CHAR_SIGNED): Replace by gdbarch_char_signed. * gdbtypes.c (build_gdbtypes, gdbtypes_post_init): Likewise. * gdbarch.c, gdbarch.h: Regenerate. Is this ok to commit? Regards, Markus -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------000401010508090706060102 Content-Type: text/plain; name="diff-remove-TARGET_CHAR_SIGNED" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-remove-TARGET_CHAR_SIGNED" Content-length: 2993 diff -urN src/gdb/gdbarch.c dev/gdb/gdbarch.c --- src/gdb/gdbarch.c 2007-05-15 05:41:29.000000000 +0200 +++ dev/gdb/gdbarch.c 2007-05-21 06:30:10.000000000 +0200 @@ -793,11 +793,6 @@ fprintf_unfiltered (file, "gdbarch_dump: cannot_store_register = <0x%lx>\n", (long) current_gdbarch->cannot_store_register); -#ifdef TARGET_CHAR_SIGNED - fprintf_unfiltered (file, - "gdbarch_dump: TARGET_CHAR_SIGNED # %s\n", - XSTRING (TARGET_CHAR_SIGNED)); -#endif fprintf_unfiltered (file, "gdbarch_dump: char_signed = %s\n", paddr_d (current_gdbarch->char_signed)); diff -urN src/gdb/gdbarch.h dev/gdb/gdbarch.h --- src/gdb/gdbarch.h 2007-05-15 05:41:29.000000000 +0200 +++ dev/gdb/gdbarch.h 2007-05-21 06:30:00.000000000 +0200 @@ -245,12 +245,6 @@ extern int gdbarch_char_signed (struct gdbarch *gdbarch); extern void set_gdbarch_char_signed (struct gdbarch *gdbarch, int char_signed); -#if !defined (GDB_TM_FILE) && defined (TARGET_CHAR_SIGNED) -#error "Non multi-arch definition of TARGET_CHAR_SIGNED" -#endif -#if !defined (TARGET_CHAR_SIGNED) -#define TARGET_CHAR_SIGNED (gdbarch_char_signed (current_gdbarch)) -#endif #if defined (TARGET_READ_PC) /* Legacy for systems yet to multi-arch TARGET_READ_PC */ diff -urN src/gdb/gdbarch.sh dev/gdb/gdbarch.sh --- src/gdb/gdbarch.sh 2007-05-15 05:41:29.000000000 +0200 +++ dev/gdb/gdbarch.sh 2007-05-21 06:29:54.000000000 +0200 @@ -417,7 +417,7 @@ v:TARGET_BFD_VMA_BIT:int:bfd_vma_bit:::8 * sizeof (void*):TARGET_ARCHITECTURE->bits_per_address::0 # # One if \`char' acts like \`signed char', zero if \`unsigned char'. -v:TARGET_CHAR_SIGNED:int:char_signed:::1:-1:1 +v::int:char_signed:::1:-1:1 # F:TARGET_READ_PC:CORE_ADDR:read_pc:ptid_t ptid:ptid f:TARGET_WRITE_PC:void:write_pc:CORE_ADDR val, ptid_t ptid:val, ptid:0:generic_target_write_pc::0 diff -urN src/gdb/gdbtypes.c dev/gdb/gdbtypes.c --- src/gdb/gdbtypes.c 2007-05-18 05:34:56.000000000 +0200 +++ dev/gdb/gdbtypes.c 2007-05-21 06:32:42.000000000 +0200 @@ -3418,7 +3418,8 @@ builtin_type_char = init_type (TYPE_CODE_INT, TARGET_CHAR_BIT / TARGET_CHAR_BIT, (TYPE_FLAG_NOSIGN - | (TARGET_CHAR_SIGNED ? 0 : TYPE_FLAG_UNSIGNED)), + | (gdbarch_char_signed (current_gdbarch) ? + 0 : TYPE_FLAG_UNSIGNED)), "char", (struct objfile *) NULL); builtin_type_true_char = init_type (TYPE_CODE_CHAR, TARGET_CHAR_BIT / TARGET_CHAR_BIT, @@ -3612,7 +3613,8 @@ builtin_type->builtin_char = init_type (TYPE_CODE_INT, TARGET_CHAR_BIT / TARGET_CHAR_BIT, (TYPE_FLAG_NOSIGN - | (TARGET_CHAR_SIGNED ? 0 : TYPE_FLAG_UNSIGNED)), + | (gdbarch_char_signed (current_gdbarch) ? + 0 : TYPE_FLAG_UNSIGNED)), "char", (struct objfile *) NULL); builtin_type->builtin_true_char = init_type (TYPE_CODE_CHAR, TARGET_CHAR_BIT / TARGET_CHAR_BIT, --------------000401010508090706060102--