From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id V/yWNH4mPmbuEA0AWB0awg (envelope-from ) for ; Fri, 10 May 2024 09:51:58 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=eCTzuiiv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C4C5A1E0C1; Fri, 10 May 2024 09:51:58 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 577AF1E030 for ; Fri, 10 May 2024 09:51:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0D95D3844031 for ; Fri, 10 May 2024 13:51:56 +0000 (GMT) Received: from sonic307-53.consmr.mail.ir2.yahoo.com (sonic307-53.consmr.mail.ir2.yahoo.com [87.248.110.30]) by sourceware.org (Postfix) with ESMTPS id 9AABC3849AEA for ; Fri, 10 May 2024 13:51:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9AABC3849AEA Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9AABC3849AEA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=87.248.110.30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715349098; cv=none; b=Xa/Q0wbR5cBJ8Iz5VzqKWSJ++jQyLKAi6ehjUhJSawYpJ6RKZZvHHo6VQ80lPVV8A45hQeM2tJpPx1dcV1HObeoNCPwG0Y1fiAuU9FEBI1GxeYPvl5n631n2uZkUGTuETGsfOHpJ9rFSR6S+vYObnbQMPOFIIMi5gd8brxH0XhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715349098; c=relaxed/simple; bh=1R0pBOwDd6PBNBdePnnpznX5JkzNe3H9Q6ozZfGneUg=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=cmPlZ85StoBeg+xKb0b0Cd1XJkzpa6L/c7lRNP6tUN9Dkubg435y/UOUhuuaTIv/RUAWBxlNpdjoL8DsQS/oWnwtQnDyBblvJzb+iMnwrBwCJ8q7OVz+lxPJE2xh6Sknks4LGTOgX6LbAUPljnGuG9GQTZomF6gL8YsVZ9GZJvA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1715349095; bh=1R0pBOwDd6PBNBdePnnpznX5JkzNe3H9Q6ozZfGneUg=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=eCTzuiivI9iYM5Jqx2fyYH7ypDgko206laOaYhVb/Ov8ofc8s3bpHN9fQrSceIwLYWxCRvO3Gqi+jE+AO2ZdtRHEkZElLrJaUs0tCqXSTW85FEEZDf5dBbsWtcZ5s9S0YGrk5fA96cFzl6ahJdeNjrgacHkOeb0a64kesIqouXPB/CwSXhefZDkzX6h8y6bq6JJZ2SO1rLtRKqSMyCaM8h4rPoQqd3rsSwwE1V89A09nuv8/6Aa7b6SAvRb3ARN76+Nz0mtxgRNjkXBxK+ZcqnP0LQaPc6gGYP53MwZJ5IgH+5Ajsaxco2DwZCgsNxU637wBjqgDHdxIGqCAehIe2Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1715349095; bh=XjK//tch2LzbV2bMMg7r4iEIkMyboQ6f+Gz45Teww9r=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=Bo29Q9TdKt0PH4imW2bYIelNNgUvad2fUNH/dVHfTyMOHTKeZufcUcHpRDquEeQUpzjPqLGHtBYhn9uuC5dXSseFjyARFdceSnp0Sui8i2wzQEn1zro2UsqFjWfTTeYRVo4Hri54IbMb7UJ1e2PY2KuQ+osOLpQTwni2bBDegTmrurErxxa/9CTfvZqPIkjVkfJutDElNwbdctj+E2u2NTI+ZV5rXxeWRVQCvwE01hIo0suEa1sNlK8NOvxWxUVA6dWAVD62ESVLz8pUt1gsvq8Bue7s5Pa2KaCoRq/Xx1wNGRYAhqf1uywYV0vj7xq3zRfl+l10/Udy9VTTp2ltJg== X-YMail-OSG: uIfUZ1kVM1lAlrkx9vYRq__Aye0C4eSe1JZpLtjxuAvEqsXsNTVeJ4y42nyQEgQ zg_uwDEv9TGDqMAq4fQeDd5a0wR0oPMbgfHdWOpx4SHD7pTq86xEVXt2Uyy9VIhdUCGU2KAm8y33 fjvA2Mw.zV7D6eVvkq3P7zYal2U7gGSwqeCsm0oPYfzCAar4O6YoH4MOmEGVsn90cvmCjyR9oFcf gfQKscHaoUiIh710qJlnect1pR23Dwgco8VcrOGFMncoPiFnqLDcwTN65X_kP.u3pH20HPa3U3NQ orhd1I3c6bcgUL87GM7b_FH6l1Z2O0XkBwlmGmREpYPJkbEQ5VtiVkmy7pziQVN8ckE9UWPW9l8A Q6NukPGyGaQR3_.VKbXVcaonONEA_weNIKnNUa3D5a4F3gNVXu.b5mzLIb6oK9AXln5LXyvXJzVz qmh1q1bTOIVLKpbZ7eqqPr_XZN23B_7tL8A0Y54KElLGxF4Qt7TFFYjTRVt7Yn_ofy2NVevJM0RF UakgzLFcX5gSrxjc8oo3Z3RX7nde5BX0tWrUMkTq6dVL..Cy8xczZb8CJ.moYMDhN_93mrT3XFGO lLogIOaMTWQ1VWpEPIaqU6NzmxbbZviwmg59UMZ1_MirH7Y8TeERd2349Dj.Y29K4Si35dr3uHSB sKzQOXLQfxsmzjiB77herw6syqzKw3FL94am6.c7HCNfoThFBJVX79ne93MSIthv4i_ZGOqxGXDO NSHC3MRxGry_g_fJvPJ.rp23rbQy9S7ORtFhRadkc8HAQkbnIXs7pH4k55I9Nzwh4xqF4Aun6GPQ pdPxx5.tNjk6TwCXDfgGjEULb4_2YeduvGycPX05.4kU5JLJMmCqbKttz5b2oT2blOcISnJRG56Q OgbfEmclWQW3F10FMoNV99DYIXEYgyIvre7_a5yxjry3ntnxqOzIcjc1tvPBuhP69Q88Z0T5vB93 0tEvKV86Ed5.9KENuASepMhqhIzMQot2rO2DRfxMjLZHl6iG2FUDLQXh_1RUK6AKQDhvrl.U_cEl 6mjpahYNQyb5As.8USEobsVVMSg0szLiXNsT3p5E7RDnIK0YPRe.yuXzZd_B1LK1UErVr.nRuH7O cbWvW_qi_ICrLNsIFiLsfgf30iVhvMqX40YnxYpKBRnVBOZXGBMajEC5cv60VbtTVJ68HSr7s628 2VqHwNpKKu.E4K6ewXdOwqw2P6CFFhDj95MaAt6REGbtKkVj1VrKDKHI7kEP_VK4gMwI_tFKPDPJ 3nnvmmzMw0ivxcrAyDr4UkULAe5rgIfgJEYhvvki5ZDAISdd_4yRX_TIIQWdVEZO2YgJ.qsWDWm4 2zbr6UZGNhCurN4r1vY9am_wm3aVSQfUsUj75_7O2T39dTdESBvBOXvctfsasFVO__9MQbH5lVnt xfh2d5pvzOXGZL1ZNuV1FkFcixTd.p7YSGJiUT9XvyVy.OdOzcQiY6o7R_sR9syA.mJ1tgY1BB0E YHvcAym36.0zBICutfGy.daU2c825UUOvgxUYSixLILF3nc2X91aE2QyviciM.5KhpD67RoGD5i7 3bk2Y2jin2nabATUgxmfgcZ2gVmO3C6CgkyXP4BBtiOEfqUz.964Ybz5TscfZ8Qr353utHmNND7b n73sJg8hPy8de1DF9a19ne23uKtsuf0UPHemtiwL_CpnguS0uLNegLD7CTo3KSFvyKyblwV9MDB_ yNd7cUUak_bhGxARlHRxvw0zc.p1nUXyPAK2m58ukDWRCHlzj100HiMpRVT3MuixYZGkjE9VnM2M PVznrsT82ur5iB.A9Bjwt9N5Lp3KfUzmmjyhrIghwlRLkowl8Ty9NaXlfCJUg5qPYRC2ZuqGiJlv ptnwkGt4Tqa._Zk9geySOrBff5nxrFB9_lQnpal03a2WBMEd2gvkBeVoN5RmD4Zit0umx0PLK_sS HwfhiLIpicuzzBZy8VKqD.7kPMUEhAg6DWSVHNNHfClRG9eQhC.tl_tnccD.nwf8LvRdZoJf.697 dXWiEDuUQVRqcFbJ37n173Z63UlkvmS0Qu5ZYOZpR1092kX9OI_0xO3iE_bRqzch2jDb0p4gEtOa k1VBIwGgg2.SzVraJOxrMsBbSVWxS_LkDBqHnHMP59FArQc6PA0.RUwX14oT1CWlvV_qcwhfyTry JrdowdYoMARjb0wG50YOjLjYQnKn_5U9m67PhO9tujJGcyb9ZoRa9EpiM7cTWHrPOCEcxFpi83eS oKgkysocmhNyt_JE7tbvZaz43.4A- X-Sonic-MF: X-Sonic-ID: 7b7a46e1-0051-493d-9c88-a93b95fddfef Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Fri, 10 May 2024 13:51:35 +0000 Date: Fri, 10 May 2024 13:50:46 +0000 (UTC) From: Hannes Domani To: Tom Tromey , Bernd Edlinger Cc: "gdb-patches@sourceware.org" Message-ID: <465944236.1425864.1715349046776@mail.yahoo.com> In-Reply-To: <7fe48268-18d8-4c0f-8d2c-b763d82cf8db@hotmail.de> References: <20240504110942.922-1-ssbssa.ref@yahoo.de> <20240504110942.922-1-ssbssa@yahoo.de> <878r0p1szk.fsf@tromey.com> <1287184562.10844646.1714841805671@mail.yahoo.com> <7fe48268-18d8-4c0f-8d2c-b763d82cf8db@hotmail.de> Subject: Re: [PATCH] Fix heap-use-after-free in index-cached with --disable-threading MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.22321 YMailNorrin X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Am Freitag, 10. Mai 2024 um 07:57:58 MESZ hat Bernd Edlinger Folgendes geschrieben: > On 5/4/24 18:56, Hannes Domani wrote: > > >=C2=A0 Am Samstag, 4. Mai 2024 um 17:45:06 MESZ hat Tom Tromey Folgendes geschrieben: > > > >>>>>>> "Hannes" =3D=3D Hannes Domani writes: > >> > >> Hannes> Fixed by making cooked_index_worker::wait only return true if = desired_state > >> Hannes> is CACHE_DONE, same as if threading was enabled, so m_state wi= ll not be > >> Hannes> prematurely deleted. > >> > >> Hannes> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31694 > >> > >> Thank you.=C2=A0 This is ok. > >> Approved-By: Tom Tromey > > > > Pushed, thanks. > > > > > > Hannes > > > > Hi, > > due to this incident you fixed here, I did some testing with tsan, > and found a couple issues that I think are important, but I have no > good idea how to solve them. > https://sourceware.org/bugzilla/show_bug.cgi?id=3D31713 > https://sourceware.org/bugzilla/show_bug.cgi?id=3D31715 > https://sourceware.org/bugzilla/show_bug.cgi?id=3D31716 > > I have found an issue (bug#31715) with the function > cooked_index_worker::wait that was changed here. > In one of the tsan reports I see something interesting here: > https://sourceware.org/bugzilla/attachment.cgi?id=3D15506 > The cooked_index_worker::wait apparently proceeds and reads > the "canonical" using cooked_index_entry::full_name > without lock, and later a worker thread changes this value > also without lock. > Do you have any idea what is going on here? Looks to me they are because while the background DWARF reading is happenin= g, gdb is processing some command (break/load/set), and both are accessing the same memory. Hannes