From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9922 invoked by alias); 16 Feb 2017 15:23:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9905 invoked by uid 89); 16 Feb 2017 15:23:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=dwarf2readc, dwarf2read.c, UD:dwarf2read.c X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Feb 2017 15:23:54 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BE50C7FB6B; Thu, 16 Feb 2017 15:23:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD545ACB83; Thu, 16 Feb 2017 15:23:53 +0000 (UTC) Subject: Re: [PATCH 1/8] Rename read_unsigned_leb128 to gdb_read_unsigned_leb128 To: Jan Kratochvil , gdb-patches@sourceware.org References: <148693097396.9024.2288256732840761882.stgit@host1.jankratochvil.net> Cc: Victor Leschuk From: Pedro Alves Message-ID: <463df715-da64-57a4-3237-99826918def1@redhat.com> Date: Thu, 16 Feb 2017 15:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <148693097396.9024.2288256732840761882.stgit@host1.jankratochvil.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00442.txt.bz2 On 02/12/2017 08:22 PM, Jan Kratochvil wrote: > Hi, > > read_unsigned_leb128 needs to be used outside of dwarf2read.c, removing its > static qualifier. But then it would clash with bfd/libbfd.c > read_unsigned_leb128 global function of the same name. Can't we just use bfd's version? How is gdb's version different? Thanks, Pedro Alves