From: Markus Deuling <deuling@de.ibm.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: [rfc]: Fix gdb.base/gcore.exp
Date: Thu, 03 May 2007 17:09:00 -0000 [thread overview]
Message-ID: <463A1707.9070801@de.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
Hi,
gdb.base/gcore.exp quits with a tcl error because of an uninitialized variable.
This patch initializes it in every case.
Is this ok ?
ChangeLog:
* gdb.base/gcore.exp: Initialize variable
core_supported.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
[-- Attachment #2: diff-fix-gcore-exp --]
[-- Type: text/plain, Size: 534 bytes --]
diff -urN src/gdb/testsuite/gdb.base/gcore.exp dev/gdb/testsuite/gdb.base/gcore.exp
--- src/gdb/testsuite/gdb.base/gcore.exp 2007-01-09 18:59:11.000000000 +0100
+++ dev/gdb/testsuite/gdb.base/gcore.exp 2007-05-03 19:04:07.000000000 +0200
@@ -108,6 +108,7 @@
set escapedfilename [string_to_regexp ${objdir}/${subdir}/gcore.test]
+set core_supported 0
gdb_test_multiple "gcore ${objdir}/${subdir}/gcore.test" \
"save a corefile" \
{
@@ -123,7 +124,6 @@
}
}
-global core_supported
if {!$core_supported} {
return -1
}
next reply other threads:[~2007-05-03 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 17:09 Markus Deuling [this message]
2007-05-08 18:27 ` Ulrich Weigand
2007-05-08 18:37 ` Daniel Jacobowitz
2007-05-09 11:43 ` Markus Deuling
2007-05-11 17:56 ` Daniel Jacobowitz
2007-05-14 21:07 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463A1707.9070801@de.ibm.com \
--to=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox