From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12986 invoked by alias); 2 May 2007 16:18:02 -0000 Received: (qmail 12942 invoked by uid 22791); 2 May 2007 16:18:01 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 02 May 2007 16:17:58 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l42GHt1B350514 for ; Wed, 2 May 2007 16:17:55 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l42GHttJ4005942 for ; Wed, 2 May 2007 18:17:55 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l42GHtqv017982 for ; Wed, 2 May 2007 18:17:55 +0200 Received: from [9.145.139.10] (sig-9-145-139-10.de.ibm.com [9.145.139.10]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l42GHqLx017950 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 2 May 2007 18:17:54 +0200 Message-ID: <4638B95C.5060900@de.ibm.com> Date: Wed, 02 May 2007 16:18:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: GDB Patches , drow@false.org Subject: Re: [rfc] Fix qC handling in gdbserver References: <4631ADC8.6000603@de.ibm.com> <20070427112726.GA15057@caradoc.them.org> In-Reply-To: <20070427112726.GA15057@caradoc.them.org> Content-Type: multipart/mixed; boundary="------------010600000003040907040200" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00036.txt.bz2 This is a multi-part message in MIME format. --------------010600000003040907040200 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 984 Hi, Daniel Jacobowitz wrote: > > GDB is opening /proc/pid on the _local_ machine. That's silly. > gdbserver is usually running on a remote machine; it's only on the > local machine during native testing. The testcase fails because info > proc only works for native targets. thank you again for your input. The patch attached disables gdb.base/info-proc.exp for remote targets. Is this ok? ChangeLog: * gdb.base/info-proc.exp: Check is_remote. Btw, shall I rework the qC-Patch () and remove the space? Like + /* Reply the current thread id. */ + if (strcmp ("qC", own_buf) == 0) + { + sprintf (own_buf, "QC%lx", + ((struct inferior_list_entry *) current_inferior)->id); + return; + } ? Would that be ok for mainline? I wonder why the manual contains qC packets while gdb does not? Is this a new feature or one that should be removed from manual rather? Thanks in advance. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------010600000003040907040200 Content-Type: text/plain; name="diff-remote-info-proc" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-remote-info-proc" Content-length: 381 diff -urN src/gdb/testsuite/gdb.base/info-proc.exp dev/gdb/testsuite/gdb.base/info-proc.exp --- src/gdb/testsuite/gdb.base/info-proc.exp 2007-01-09 18:59:11.000000000 +0100 +++ dev/gdb/testsuite/gdb.base/info-proc.exp 2007-05-02 18:04:33.000000000 +0200 @@ -24,6 +24,10 @@ strace $tracelevel } +if { [is_remote target] } then { + continue +} + set prms_id 0 set bug_id 0 --------------010600000003040907040200--